Skip to content

Conversation

selenium-ci
Copy link
Member

@selenium-ci selenium-ci commented Oct 3, 2025

User description

This PR contains the CHANGELOG for Node/Standalone with backward browser versions


PR Type

Other


Description

  • Update browser version matrices for Chrome and Edge

  • Add Chrome/Edge 140 and 141 support

  • Update Firefox version to 143.0.3


Diagram Walkthrough

flowchart LR
  A["Browser Matrix Files"] --> B["Add Chrome 140"]
  A --> C["Add Edge 140"]
  A --> D["Update Firefox 143.0.3"]
  B --> E["Updated CI Workflows"]
  C --> E
Loading

File Walkthrough

Relevant files
Configuration changes
release-chrome-versions.yml
Add Chrome 140 support                                                                     

.github/workflows/release-chrome-versions.yml

  • Add Chrome version 140 to the default browser versions list
+1/-1     
release-edge-versions.yml
Add Edge 140 support                                                                         

.github/workflows/release-edge-versions.yml

  • Add Edge version 140 to the default browser versions list
+1/-1     
browser-matrix.yml
Update browser matrix with new versions                                   

tests/build-backward-compatible/browser-matrix.yml

  • Update Firefox version from 143.0.1 to 143.0.3
  • Add Chrome and Edge version 141 with specific package versions
+3/-3     
firefox-matrix.yml
Update Firefox to 143.0.3                                                               

tests/build-backward-compatible/firefox-matrix.yml

  • Update Firefox version from 143.0.1 to 143.0.3
+1/-1     

Copy link
Contributor

qodo-merge-pro bot commented Oct 3, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

qodo-merge-pro bot commented Oct 3, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Update workflow with new browser version

Add Chrome version 141 to the default browser-versions list in the
release-chrome-versions.yml workflow to align with the changes in
browser-matrix.yml.

.github/workflows/release-chrome-versions.yml [34]

-default: '[95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140]'
+default: '[95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141]'
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a logical inconsistency where version 141 was added to the test matrix but missed in the release workflow's default configuration, which is a significant oversight in this PR.

Medium
Learned
best practice
Quote package pin strings

Quote the package pin strings to ensure they are treated as plain scalars and
not misinterpreted by YAML parsers.

tests/build-backward-compatible/browser-matrix.yml [9-11]

 '141':
-  EDGE_VERSION: microsoft-edge-stable=141.0.3537.57-1
-  CHROME_VERSION: google-chrome-stable=141.0.7390.54-1
+  EDGE_VERSION: "microsoft-edge-stable=141.0.3537.57-1"
+  CHROME_VERSION: "google-chrome-stable=141.0.7390.54-1"
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why:
Relevant best practice - Harden YAML templating by quoting values that include special characters like '=' to avoid parsing ambiguities.

Low
  • Update

@selenium-ci selenium-ci force-pushed the browser-node-changelog branch from bcd466c to 254b56b Compare October 3, 2025 11:44
@VietND96 VietND96 force-pushed the ci-release-browser branch from 7908ffe to ba3b559 Compare October 3, 2025 13:04
@VietND96 VietND96 closed this Oct 3, 2025
@VietND96 VietND96 deleted the browser-node-changelog branch October 3, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants