fix binary driver issue

Author: toddtarsi

packages/selenium-ide/package.json

@@ -1,6 +1,6 @@
 {
   "name": "selenium-ide",
-  "version": "4.0.1-alpha.69",
+  "version": "4.0.1-alpha.70",
   "private": false,
   "description": "Selenium IDE electron app",
   "author": "Todd <[email protected]>",

packages/selenium-ide/src/main/session/controllers/Driver/start.ts

@@ -31,24 +31,13 @@ export const port = app.isPackaged ? 9516 : 9515
  */
 
 const electronBinary = `chromedriver${os.platform() === 'win32' ? '.exe' : ''}`
-const ourElectronPath = app.isPackaged
-  ? path.resolve(
-      path.join(
-        __dirname,
-        '..',
-        'node_modules',
-        'electron-chromedriver',
-        'bin',
-        electronBinary
-      )
-    )
-  : __non_webpack_require__.resolve(
-      path.join(
-        'electron-chromedriver',
-        'bin',
-        electronBinary
-      )
-    )
+const ourElectronPath = __non_webpack_require__.resolve(
+  path.join(
+    'electron-chromedriver',
+    'bin',
+    electronBinary
+  )
+)
 
 const getDriver = ({ browser, version }: BrowserInfo) =>
   (browser === 'electron'

packages/selenium-ide/src/main/session/controllers/System/index.ts

@@ -56,13 +56,28 @@ export default class SystemController extends BaseController {
       loggerWindow.show()
       // If automated, assume we already have a chromedriver process running
       if (!isAutomated) {
-        const startupError = await this.session.driver.startProcess(
-          this.session.store.get('browserInfo')
-        )
-        if (startupError) {
-          await this.crash(
-            `Unable to startup due to chromedriver error: ${startupError}`
+        try {
+          await this.session.driver.startProcess(
+            this.session.store.get('browserInfo')
           )
+        } catch (e) {
+          console.warn(`
+            Failed to locate non-electron driver on startup,
+            Resetting to electron driver.
+          `)
+          await this.session.store.set('browserInfo', {
+            browser: 'electron',
+            useBidi: false,
+            version: '',
+          })
+          const startupError = await this.session.driver.startProcess(
+            this.session.store.get('browserInfo')
+          )
+          if (startupError) {
+            await this.crash(
+              `Unable to startup due to chromedriver error: ${startupError}`
+            )
+          }
         }
       }
       await this.session.projects.select(firstTime)

packages/selenium-ide/src/main/store/index.ts

@@ -33,7 +33,7 @@ export default () => {
   const store = new Store<StorageSchema>({
     defaults: {
       browserInfo: {
-        browser: 'chrome',
+        browser: 'electron',
         useBidi: false,
         version: '',
       },