Skip to content

Commit f9a3b84

Browse files
committed
make sure whatwg URL is defined
1 parent 638b0fb commit f9a3b84

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/selianize/__tests__/configuration.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe("configuration code emitter", () => {
2222
const project = {
2323
url: "http://www.seleniumhq.org"
2424
};
25-
return expect(ConfigurationEmitter.emit(project)).resolves.toBe(`global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};`);
25+
return expect(ConfigurationEmitter.emit(project)).resolves.toBe(`global.URL = require('url').URL;global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};`);
2626
});
2727
it("should skip emitting project configuration when skipStdLibEmitting is set and there are no config hooks", () => {
2828
const project = {
@@ -37,7 +37,7 @@ describe("configuration code emitter", () => {
3737
url: "http://www.seleniumhq.org"
3838
};
3939
const snapshot = "extra global config";
40-
return expect(ConfigurationEmitter.emit(project, undefined, snapshot)).resolves.toBe(`global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};${snapshot}`);
40+
return expect(ConfigurationEmitter.emit(project, undefined, snapshot)).resolves.toBe(`global.URL = require('url').URL;global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};${snapshot}`);
4141
});
4242
it("should emit a snapshot of the hooks when skipStdLibEmitting is set", () => {
4343
const project = {

packages/selianize/src/configuration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const hooks = [];
2222
export async function emit(project, options = config, snapshot) {
2323
const configHooks = (await Promise.all(hooks.map((hook) => hook({ name: project.name })))).join("");
2424
if (!options.skipStdLibEmitting) {
25-
return `global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};${configHooks}${snapshot ? snapshot : ""}`;
25+
return `global.URL = require('url').URL;global.BASE_URL = configuration.baseUrl || '${project.url}';let vars = {};${configHooks}${snapshot ? snapshot : ""}`;
2626
} else {
2727
if (configHooks) {
2828
return {

0 commit comments

Comments
 (0)