updated event_name for continue, still failing

Author: shbenzer

py/selenium/webdriver/common/bidi/network.py

@@ -35,7 +35,8 @@ class Network:
         "response_completed": "network.responseCompleted",
         "auth_required": "network.authRequired",
         "fetch_error": "network.fetchError",
-        "continue_request": "network.continueWithRequest",
+        "continue_request": "network.continueRequest",
+        "continue_auth": "network.continueWithAuth",
     }
 
     PHASES = {
@@ -225,12 +226,12 @@ def add_auth_handler(self, username, password):
             username (str): The username to authenticate with.
             password (str): The password to authenticate with.
         """
-        event_name = "auth_required"
+        event = "auth_required"
 
         def _callback(request):
             self._continue_with_auth(request, username, password)
 
-        return self.add_request_handler(event_name, _callback)
+        return self.add_request_handler(event, _callback)
 
     def _continue_with_auth(self, request, username, password):
         """Continue with authentication."""
@@ -300,4 +301,4 @@ def continue_request(self, **kwargs):
         if self.url is not None:
             params["url"] = self.url
 
-        self.network.conn.execute(self.command_builder("network.continueWithRequest", params))
+        self.network.conn.execute(self.command_builder("network.continueRequest", params))

py/test/selenium/webdriver/common/bidi_network_tests.py

@@ -21,38 +21,38 @@
 from selenium.webdriver.common.by import By
 
 
-@pytest.mark.xfail_safari
-def test_network_initialized(driver):
-    assert driver.network is not None
+# @pytest.mark.xfail_safari
+# def test_network_initialized(driver):
+#     assert driver.network is not None
 
 
-@pytest.mark.xfail_safari
-def test_add_intercept(driver, pages):
-    result = driver.network.add_intercept()
-    assert result is not None, "Intercept not added"
+# @pytest.mark.xfail_safari
+# def test_add_intercept(driver, pages):
+#     result = driver.network.add_intercept()
+#     assert result is not None, "Intercept not added"
 
 
-@pytest.mark.xfail_safari
-def test_remove_intercept(driver):
-    result = driver.network.add_intercept()
-    driver.network.remove_intercept(result["intercept"])
-    assert driver.network.intercepts == [], "Intercept not removed"
+# @pytest.mark.xfail_safari
+# def test_remove_intercept(driver):
+#     result = driver.network.add_intercept()
+#     driver.network.remove_intercept(result["intercept"])
+#     assert driver.network.intercepts == [], "Intercept not removed"
 
 
-@pytest.mark.xfail_safari
-def test_add_and_remove_request_handler(driver, pages):
+# @pytest.mark.xfail_safari
+# def test_add_and_remove_request_handler(driver, pages):
 
-    requests = []
+#     requests = []
 
-    def callback(request: Request):
-        requests.append(request)
+#     def callback(request: Request):
+#         requests.append(request)
 
-    callback_id = driver.network.add_request_handler("before_request", callback)
-    assert callback_id is not None, "Request handler not added"
-    driver.network.remove_request_handler("before_request", callback_id)
-    pages.load("formPage.html")
-    assert not requests, "Requests intercepted"
-    assert driver.find_element(By.NAME, "login").is_displayed(), "Request not continued"
+#     callback_id = driver.network.add_request_handler("before_request", callback)
+#     assert callback_id is not None, "Request handler not added"
+#     driver.network.remove_request_handler("before_request", callback_id)
+#     pages.load("formPage.html")
+#     assert not requests, "Requests intercepted"
+#     assert driver.find_element(By.NAME, "login").is_displayed(), "Request not continued"
 
 
 @pytest.mark.xfail_safari
@@ -67,10 +67,10 @@ def callback(request: Request):
     assert driver.find_element(By.NAME, "login").is_displayed(), "Request not continued"
 
 
-@pytest.mark.xfail_safari
-def test_continue_with_auth(driver):
+# @pytest.mark.xfail_safari
+# def test_continue_with_auth(driver):
 
-    callback_id = driver.network.add_auth_handler("user", "passwd")
-    assert callback_id is not None, "Request handler not added"
-    driver.get("https://httpbin.org/basic-auth/user/passwd")
-    assert "authenticated" in driver.page_source, "Authorization failed"
+#     callback_id = driver.network.add_auth_handler("user", "passwd")
+#     assert callback_id is not None, "Request handler not added"
+#     driver.get("https://httpbin.org/basic-auth/user/passwd")
+#     assert "authenticated" in driver.page_source, "Authorization failed"