Skip to content

Commit 789aa2d

Browse files
authored
Merge branch 'trunk' into convert_to_BIG_SNAKE_CASE
2 parents 09d3372 + 39c38e4 commit 789aa2d

File tree

158 files changed

+394
-247
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

158 files changed

+394
-247
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,3 +140,4 @@ javascript/node/selenium-webdriver/.vscode/settings.json
140140

141141
dotnet-bin
142142
.metadata/
143+
.npmrc

dotnet/src/webdriver/BUILD.bazel

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ csharp_library(
6767
"**/*.cs",
6868
]) + devtools_version_targets(),
6969
out = "WebDriver",
70+
defines = [
71+
"NET8_0_OR_GREATER",
72+
],
7073
internals_visible_to = [
7174
"WebDriver.Common.Tests",
7275
],
@@ -128,6 +131,9 @@ csharp_library(
128131
"**/*.cs",
129132
]) + devtools_version_targets(),
130133
out = "WebDriver.StrongNamed",
134+
defines = [
135+
"NET8_0_OR_GREATER",
136+
],
131137
keyfile = "//dotnet:WebDriver.snk",
132138
langversion = "12.0",
133139
resources = [

dotnet/src/webdriver/BiDi/BiDi.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@ public static async Task<BiDi> ConnectAsync(string url)
6060
return bidi;
6161
}
6262

63-
public Task<Modules.BrowsingContext.BrowsingContext> CreateBrowsingContextAsync(Modules.BrowsingContext.BrowsingContextType type, Modules.BrowsingContext.CreateOptions? options = null)
63+
public Task<Modules.BrowsingContext.BrowsingContext> CreateContextAsync(Modules.BrowsingContext.ContextType type, Modules.BrowsingContext.CreateOptions? options = null)
6464
{
6565
return BrowsingContextModule.CreateAsync(type, options);
6666
}
6767

68-
public Task<IReadOnlyList<Modules.BrowsingContext.BrowsingContextInfo>> GetBrowsingContextTreeAsync(Modules.BrowsingContext.GetTreeOptions? options = null)
68+
public Task<IReadOnlyList<Modules.BrowsingContext.BrowsingContextInfo>> GetTreeAsync(Modules.BrowsingContext.GetTreeOptions? options = null)
6969
{
7070
return BrowsingContextModule.GetTreeAsync(options);
7171
}
@@ -82,22 +82,22 @@ public async ValueTask DisposeAsync()
8282
_transport?.Dispose();
8383
}
8484

85-
public Task<Subscription> OnBrowsingContextCreatedAsync(Func<Modules.BrowsingContext.BrowsingContextInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
85+
public Task<Subscription> OnContextCreatedAsync(Func<Modules.BrowsingContext.BrowsingContextInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
8686
{
8787
return BrowsingContextModule.OnContextCreatedAsync(handler, options);
8888
}
8989

90-
public Task<Subscription> OnBrowsingContextCreatedAsync(Action<Modules.BrowsingContext.BrowsingContextInfo> handler, BrowsingContextsSubscriptionOptions? options = null)
90+
public Task<Subscription> OnContextCreatedAsync(Action<Modules.BrowsingContext.BrowsingContextInfo> handler, BrowsingContextsSubscriptionOptions? options = null)
9191
{
9292
return BrowsingContextModule.OnContextCreatedAsync(handler, options);
9393
}
9494

95-
public Task<Subscription> OnBrowsingContextDestroyedAsync(Func<Modules.BrowsingContext.BrowsingContextInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
95+
public Task<Subscription> OnContextDestroyedAsync(Func<Modules.BrowsingContext.BrowsingContextInfo, Task> handler, BrowsingContextsSubscriptionOptions? options = null)
9696
{
9797
return BrowsingContextModule.OnContextDestroyedAsync(handler, options);
9898
}
9999

100-
public Task<Subscription> OnBrowsingContextDestroyedAsync(Action<Modules.BrowsingContext.BrowsingContextInfo> handler, BrowsingContextsSubscriptionOptions? options = null)
100+
public Task<Subscription> OnContextDestroyedAsync(Action<Modules.BrowsingContext.BrowsingContextInfo> handler, BrowsingContextsSubscriptionOptions? options = null)
101101
{
102102
return BrowsingContextModule.OnContextDestroyedAsync(handler, options);
103103
}

dotnet/src/webdriver/BiDi/BiDiException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22

33
namespace OpenQA.Selenium.BiDi;
44

dotnet/src/webdriver/BiDi/Communication/Broker.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ public Broker(BiDi bidi, ITransport transport)
5858
new RealmConverter(_bidi),
5959
new RealmTypeConverter(),
6060
new DateTimeOffsetConverter(),
61+
new PrintPageRangeConverter(),
6162
new JsonStringEnumConverter(JsonNamingPolicy.CamelCase),
6263

6364
// https://github.com/dotnet/runtime/issues/72604

dotnet/src/webdriver/BiDi/Communication/Command.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System.Text.Json.Serialization;
1+
using System.Text.Json.Serialization;
22

33
namespace OpenQA.Selenium.BiDi.Communication;
44

dotnet/src/webdriver/BiDi/Communication/CommandOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using System;
1+
using System;
22

33
namespace OpenQA.Selenium.BiDi.Communication;
44

dotnet/src/webdriver/BiDi/Communication/EventHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
1+
using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
22
using System;
33
using System.Collections.Generic;
44
using System.Threading.Tasks;

dotnet/src/webdriver/BiDi/Communication/Json/Converters/BrowserUserContextConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using OpenQA.Selenium.BiDi.Modules.Browser;
1+
using OpenQA.Selenium.BiDi.Modules.Browser;
22
using System;
33
using System.Text.Json;
44
using System.Text.Json.Serialization;

dotnet/src/webdriver/BiDi/Communication/Json/Converters/BrowsingContextConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
1+
using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
22
using System;
33
using System.Text.Json;
44
using System.Text.Json.Serialization;

0 commit comments

Comments
 (0)