Skip to content

Commit e5d0816

Browse files
committed
Caching size in loops for grid package
1 parent 0fa6913 commit e5d0816

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

java/src/org/openqa/selenium/grid/node/docker/DockerOptions.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,11 @@ public Map<Capabilities, Collection<SessionFactory>> getDockerSessionFactories(
140140
config.getAll(DOCKER_SECTION, "host-config-keys").orElseGet(Collections::emptyList);
141141

142142
Multimap<String, Capabilities> kinds = HashMultimap.create();
143-
for (int i = 0; i < allConfigs.size(); i++) {
143+
int configsCount = allConfigs.size();
144+
for (int i = 0; i < configsCount; i++) {
144145
String imageName = allConfigs.get(i);
145146
i++;
146-
if (i == allConfigs.size()) {
147+
if (i == configsCount) {
147148
throw new DockerException("Unable to find JSON config");
148149
}
149150
Capabilities stereotype =

java/src/org/openqa/selenium/grid/node/relay/RelayOptions.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,15 +153,16 @@ public Map<Capabilities, Collection<SessionFactory>> getSessionFactories(
153153
() -> new ConfigException("Unable to find configs for " + getServiceUri()));
154154

155155
Multimap<Integer, Capabilities> parsedConfigs = HashMultimap.create();
156-
for (int i = 0; i < allConfigs.size(); i++) {
156+
int configsCount = allConfigs.size();
157+
for (int i = 0; i < configsCount; i++) {
157158
int maxSessions;
158159
try {
159160
maxSessions = Integer.parseInt(extractConfiguredValue(allConfigs.get(i)));
160161
} catch (NumberFormatException e) {
161162
throw new ConfigException("Unable parse value as number. " + allConfigs.get(i));
162163
}
163164
i++;
164-
if (i == allConfigs.size()) {
165+
if (i == configsCount) {
165166
throw new ConfigException("Unable to find stereotype config. " + allConfigs);
166167
}
167168
Capabilities stereotype =

0 commit comments

Comments
 (0)