-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] Moved Rust binary settings to pyproject.toml from setup.py
#14837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@VietND96 Can you please build this one for me from CI and upload to test PyPI. So that i will verify the binaries.. |
|
I think other script need to be updated, since publish CI failed https://github.com/SeleniumHQ/selenium/actions/runs/12113072764/job/33767482214 |
|
Dist package is https://test.pypi.org/project/selenium/4.28.0.202412041759/ |
| # include-package-data is `true` by default in pyproject.toml | ||
|
|
||
| [[tool.setuptools-rust.bins]] | ||
| target = "selenium.webdriver.common.selenium-manager" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been:
[[tool.setuptools-rust.ext-modules]]
target = "selenium.webdriver.common.selenium-manager"
binding = "Exec"Fixed in #16074.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved Rust binary settings to
pyproject.tomlfromsetup.pythus completely eliminating the need ofsetup.pyMotivation and Context
setup.pyas all the settings are moved topyproject.tomlbazel build //py:selenium-wheelwhich is successful.seleniumfrom.whlfile, the installation was successful.selenium-manageris present inselenium.webdriver.commonfolder (in /linux, /macos, /windows)--no-binaryoption as well.Types of changes
Checklist
PR Type
enhancement
Description
setup.pyfile, migrating its configurations topyproject.toml.pyproject.tomlto include Rust binary settings forselenium-manager.setup.pyfrom the source files.Changes walkthrough 📝
setup.py
Remove setup.py and migrate configurationspy/setup.py
setup.pyfile entirely.setup.pyby moving configurations.pyproject.toml
Add Rust binary settings to pyproject.tomlpy/pyproject.toml
selenium-manager.BUILD.bazel
Update Bazel build configuration for setup.py removalpy/BUILD.bazel
setup.pyfrom the list of source files.