Skip to content

Conversation

@Delta456
Copy link
Member

@Delta456 Delta456 commented Apr 1, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Enables safari tests for CookieImplementationTest as they are working now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests


Description

  • Enabled Safari browser support for CookieImplementationTest.

  • Removed @NotYetImplemented(SAFARI) annotations from multiple test cases.

  • Ensured compatibility of cookie-related tests with Safari.


Changes walkthrough 📝

Relevant files
Tests
CookieImplementationTest.java
Enable Safari compatibility for cookie management tests   

java/test/org/openqa/selenium/CookieImplementationTest.java

  • Removed @NotYetImplemented(SAFARI) annotations from all relevant test
    cases.
  • Enabled Safari compatibility for cookie management tests.
  • Adjusted test cases to validate Safari's cookie handling behavior.
  • +0/-19   

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 1, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Test Validation

    The PR removes @NotYetImplemented(SAFARI) annotations from all cookie tests, but there's no evidence of actual testing to confirm Safari compatibility. Consider verifying that these tests actually pass in Safari before merging.

    public void testShouldGetCookieByName() {
      String key = generateUniqueKey();
      String value = "set";
      assertCookieIsNotPresentWithName(key);

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Apr 1, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Delta456 Delta456 requested a review from VietND96 April 2, 2025 13:01
    @titusfortner titusfortner merged commit dd789f2 into SeleniumHQ:trunk Apr 3, 2025
    10 of 11 checks passed
    @titusfortner
    Copy link
    Member

    Thanks for the update

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants