Skip to content

[java] enable safari for CookieImplementationTest #15544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 3, 2025
Merged

[java] enable safari for CookieImplementationTest #15544

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5a16b5
[java] enable safari for CookieImplementationTest
Delta456 Apr 1, 2025
2c26280
remove newline
Delta456 Apr 1, 2025
482f199
fmt
Delta456 Apr 1, 2025
f587dca
Merge branch 'trunk' into safari_cookie
VietND96 Apr 2, 2025
aafb847
Merge branch 'trunk' into safari_cookie
Delta456 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions java/test/org/openqa/selenium/CookieImplementationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import org.openqa.selenium.testing.JupiterTestBase;
import org.openqa.selenium.testing.NeedsSecureServer;
import org.openqa.selenium.testing.NotWorkingInRemoteBazelBuilds;
import org.openqa.selenium.testing.NotYetImplemented;
import org.openqa.selenium.testing.SwitchToTopAfterTest;

@NeedsSecureServer
Expand Down Expand Up @@ -74,7 +73,6 @@ public void setUp() {
}

@Test
@NotYetImplemented(SAFARI)
public void testShouldGetCookieByName() {
String key = generateUniqueKey();
String value = "set";
Expand All @@ -87,7 +85,6 @@ public void testShouldGetCookieByName() {
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
public void testShouldBeAbleToAddCookie() {
String key = generateUniqueKey();
Expand All @@ -104,7 +101,6 @@ public void testShouldBeAbleToAddCookie() {
}

@Test
@NotYetImplemented(SAFARI)
public void testGetAllCookies() {
String key1 = generateUniqueKey();
String key2 = generateUniqueKey();
Expand All @@ -130,7 +126,6 @@ public void testGetAllCookies() {
}

@Test
@NotYetImplemented(SAFARI)
public void testDeleteAllCookies() {
addCookieOnServerSide(new Cookie("foo", "set"));
assertSomeCookiesArePresent();
Expand All @@ -144,7 +139,6 @@ public void testDeleteAllCookies() {
}

@Test
@NotYetImplemented(SAFARI)
public void testDeleteCookieWithName() {
String key1 = generateUniqueKey();
String key2 = generateUniqueKey();
Expand All @@ -166,7 +160,6 @@ public void testDeleteCookieWithName() {
}

@Test
@NotYetImplemented(SAFARI)
public void testShouldNotDeleteCookiesWithASimilarName() {
String cookieOneName = "fish";
Cookie cookie1 = new Cookie.Builder(cookieOneName, "cod").build();
Expand All @@ -187,7 +180,6 @@ public void testShouldNotDeleteCookiesWithASimilarName() {
}

@Test
@NotYetImplemented(SAFARI)
public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() {
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));
Cookie cookie1 = new Cookie.Builder("fish", "cod").path("/common/animals").build();
Expand Down Expand Up @@ -224,7 +216,6 @@ public void testGetCookiesInAFrame() {
}

@Test
@NotYetImplemented(SAFARI)
public void testCannotGetCookiesWithPathDifferingOnlyInCase() {
String cookieName = "fish";
Cookie cookie = new Cookie.Builder(cookieName, "cod").path("/Common/animals").build();
Expand All @@ -235,7 +226,6 @@ public void testCannotGetCookiesWithPathDifferingOnlyInCase() {
}

@Test
@NotYetImplemented(SAFARI)
public void testShouldNotGetCookieOnDifferentDomain() {
assumeTrue(domainHelper.checkHasValidAlternateHostname());

Expand All @@ -249,7 +239,6 @@ public void testShouldNotGetCookieOnDifferentDomain() {
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
public void testShouldBeAbleToAddToADomainWhichIsRelatedToTheCurrentDomain() {
String cookieName = "name";
Expand Down Expand Up @@ -289,7 +278,6 @@ void testShouldBeAbleToIncludeLeadingPeriodInDomainName() {
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
public void testShouldBeAbleToSetDomainToTheCurrentDomain() throws Exception {
URI url = new URI(driver.getCurrentUrl());
Expand All @@ -304,7 +292,6 @@ public void testShouldBeAbleToSetDomainToTheCurrentDomain() throws Exception {
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(CHROME)
@NotWorkingInRemoteBazelBuilds(EDGE)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
Expand Down Expand Up @@ -336,7 +323,6 @@ public void testShouldWalkThePathToDeleteACookie() {
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
public void testShouldIgnoreThePortNumberOfTheHostWhenSettingTheCookie() throws Exception {
URI uri = new URI(driver.getCurrentUrl());
Expand All @@ -352,7 +338,6 @@ public void testShouldIgnoreThePortNumberOfTheHostWhenSettingTheCookie() throws
}

@Test
@NotYetImplemented(SAFARI)
@NotWorkingInRemoteBazelBuilds(CHROME)
@NotWorkingInRemoteBazelBuilds(EDGE)
@NotWorkingInRemoteBazelBuilds(FIREFOX)
Expand Down Expand Up @@ -383,7 +368,6 @@ public void testCookieEqualityAfterSetAndGet() {
}

@Test
@NotYetImplemented(SAFARI)
public void testRetainsCookieExpiry() {
Cookie addedCookie =
new Cookie.Builder("fish", "cod")
Expand Down Expand Up @@ -470,7 +454,6 @@ public void testRetainsHttpOnlyFlag() {
}

@Test
@NotYetImplemented(SAFARI)
public void testSettingACookieThatExpiredInThePast() {
long expires = System.currentTimeMillis() - 1000;
Cookie cookie = new Cookie.Builder("expired", "yes").expiresOn(new Date(expires)).build();
Expand All @@ -483,7 +466,6 @@ public void testSettingACookieThatExpiredInThePast() {
}

@Test
@NotYetImplemented(SAFARI)
public void testCanSetCookieWithoutOptionalFieldsSet() {
String key = generateUniqueKey();
String value = "foo";
Expand All @@ -496,7 +478,6 @@ public void testCanSetCookieWithoutOptionalFieldsSet() {
}

@Test
@NotYetImplemented(SAFARI)
public void testDeleteNotExistedCookie() {
String key = generateUniqueKey();
assertCookieIsNotPresentWithName(key);
Expand Down Expand Up @@ -637,7 +618,6 @@ private void addCookieOnServerSide(Cookie cookie) {
}

@Test
@NotYetImplemented(SAFARI)
public void deleteAllCookies() {
assumeTrue(domainHelper.checkHasValidAlternateHostname());

Expand Down
Loading