Skip to content

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Oct 11, 2025

User description

This pull request removes support for FTP proxies from the Proxy class and its related tests. The changes simplify the codebase by eliminating the FtpProxy property, its serialization, and all associated logic and tests. This aligns with the previous deprecation notice and helps maintain a cleaner, more focused proxy implementation.

💥 What does this PR do?

  • Removed the FtpProxy property, its backing field, and related logic from the Proxy class, including JSON serialization and dictionary conversion.
  • Removed handling of the ftpProxy key in the Proxy(Dictionary<string, object> settings) constructor.

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Other


Description

  • Remove deprecated FtpProxy property from Proxy class

  • Clean up related serialization and constructor logic

  • Update all associated unit tests


Diagram Walkthrough

flowchart LR
  A["Proxy Class"] --> B["Remove FtpProxy Property"]
  B --> C["Remove Serialization Logic"]
  B --> D["Remove Constructor Handling"]
  E["Unit Tests"] --> F["Remove FtpProxy Assertions"]
Loading

File Walkthrough

Relevant files
Cleanup
Proxy.cs
Remove FtpProxy property and related logic                             

dotnet/src/webdriver/Proxy.cs

  • Remove ftpProxyLocation field and FtpProxy property
  • Remove FTP proxy handling from constructor and serialization
  • Clean up JSON attributes and obsolete annotations
+0/-29   
Tests
ProxyTest.cs
Remove FtpProxy test assertions                                                   

dotnet/test/common/ProxyTest.cs

  • Remove all FtpProxy assertions from test methods
  • Remove FTP proxy setup from manual proxy tests
  • Clean up dictionary-based proxy construction tests
+0/-13   

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Oct 11, 2025
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@nvborisenko nvborisenko merged commit 09da0ef into SeleniumHQ:trunk Oct 11, 2025
13 checks passed
This was referenced Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants