[dotnet] Remove obsoleted FtpProxy #16411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This pull request removes support for FTP proxies from the
Proxy
class and its related tests. The changes simplify the codebase by eliminating theFtpProxy
property, its serialization, and all associated logic and tests. This aligns with the previous deprecation notice and helps maintain a cleaner, more focused proxy implementation.💥 What does this PR do?
FtpProxy
property, its backing field, and related logic from theProxy
class, including JSON serialization and dictionary conversion.ftpProxy
key in theProxy(Dictionary<string, object> settings)
constructor.🔄 Types of changes
PR Type
Other
Description
Remove deprecated
FtpProxy
property from Proxy classClean up related serialization and constructor logic
Update all associated unit tests
Diagram Walkthrough
File Walkthrough
Proxy.cs
Remove FtpProxy property and related logic
dotnet/src/webdriver/Proxy.cs
ftpProxyLocation
field andFtpProxy
propertyProxyTest.cs
Remove FtpProxy test assertions
dotnet/test/common/ProxyTest.cs
FtpProxy
assertions from test methods