-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Leaving the version block at the top of the PDL file #16448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
User description
There was an issue with the script, and it failed to include the version block at the top of the PDL file. Due to this, the generation of CDP bindings for Python was failing.
PR Type
Bug fix
Description
Preserve version block at top of PDL file during concatenation
Fix CDP binding generation failure for Python
Comment out updates for Java, .NET, Ruby, and JavaScript bindings
Diagram Walkthrough
File Walkthrough
update_cdp.py
Preserve version block in PDL concatenation for Python
scripts/update_cdp.py