Skip to content

Leaving the version block at the top of the PDL file #16448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2025
+6 −3
Merged

Leaving the version block at the top of the PDL file #16448

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e09cb72
Leaving the version block at the top of pdl file
diemol Oct 16, 2025
f573ddd
Merge branch 'trunk' into fixing_cdp_generation_for_python
diemol Oct 16, 2025
aa322ce
Uncommenting a few lines I left in that state.
diemol Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scripts/update_cdp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,12 @@ def old_chrome(chrome_milestone):


def flatten_browser_pdl(file_path, chrome_version):
"""Fetches all included domain .pdl files and concatenates them."""
"""Preserves the version block and concatenates all included domain .pdl files."""
with open(file_path, "r") as file:
content = file.read()
# Extract version block
version_match = re.search(r"(version\s+major\s+\d+\s+minor\s+\d+)", content)
version_block = version_match.group(1) + "\n\n" if version_match else ""
# Find all include lines
includes = re.findall(r"include domains/([A-Za-z0-9_]+\.pdl)", content)
base_url = f"https://raw.githubusercontent.com/chromium/chromium/{chrome_version}/third_party/blink/public/devtools_protocol/domains/"
Expand All @@ -76,9 +79,9 @@ def flatten_browser_pdl(file_path, chrome_version):
url = base_url + domain_file
response = http.request("GET", url)
concatenated += response.data.decode("utf-8") + "\n"
# Overwrite the file with concatenated domains
# Overwrite the file with version block + concatenated domains
with open(file_path, "w") as file:
file.write(concatenated)
file.write(version_block + concatenated)


def add_pdls(chrome_milestone):
Expand Down
Loading