-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java] JSpecify annotations for wrappers #14396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mk868!
This reverts commit 045ce40.
This reverts commit cce9b94.
Co-authored-by: Puja Jagani <[email protected]> Co-authored-by: Diego Molina <[email protected]> [skip ci]
User description
Description
In this PR I'm adding nullness annotations for interfaces:
WrapsDriverWrapsElementNone of the methods in these wrappers can return a null value
Motivation and Context
The JSpecify nullness annotations will give developers better exposure to potential problems with their code to avoid NullPointerExceptions.
Related issue: #14291
Types of changes
Checklist
PR Type
enhancement, documentation
Description
@NullMarkedannotations to theWrapsDriverandWrapsElementinterfaces.Changes walkthrough 📝
WrapsDriver.java
Add JSpecify nullness annotations to WrapsDriverjava/src/org/openqa/selenium/WrapsDriver.java
@NullMarkedannotation to theWrapsDriverinterface.org.jspecify.annotations.NullMarked.WrapsElement.java
Add JSpecify nullness annotations to WrapsElementjava/src/org/openqa/selenium/WrapsElement.java
@NullMarkedannotation to theWrapsElementinterface.org.jspecify.annotations.NullMarked.