Skip to content

[java]: fix decoding of line endings #14539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2024
Merged

[java]: fix decoding of line endings #14539

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ccd524
[java]: fix decoding of line endings
Delta456 Sep 26, 2024
4efc9aa
Merge branch 'trunk' into remove_line_ending_manipulation
Delta456 Oct 3, 2024
7750a13
format
Delta456 Oct 3, 2024
8e5d6f4
Merge branch 'trunk' into remove_line_ending_manipulation
harsha509 Oct 3, 2024
e5e7462
Merge branch 'trunk' into remove_line_ending_manipulation
pujagani Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions java/src/org/openqa/selenium/remote/codec/AbstractHttpResponseCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,6 @@ public Response decode(HttpResponse encodedResponse) {
response.setValue(content);
}

if (response.getValue() instanceof String) {
// We normalise to \n because Java will translate this to \r\n
// if this is suitable on our platform, and if we have \r\n, java will
// turn this into \r\r\n, which would be Bad!
response.setValue(((String) response.getValue()).replace("\r\n", "\n"));
}

if (response.getStatus() != null && response.getState() == null) {
response.setState(errorCodes.toState(response.getStatus()));
} else if (response.getStatus() == null && response.getState() != null) {
Expand Down
Loading