Skip to content

[dotnet] Don't include http headers in internal logs #14546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2024
Merged

[dotnet] Don't include http headers in internal logs #14546

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44bf8cd
[dotnet] Don't include http headers in internal logs
nvborisenko Sep 28, 2024
4c3b2ba
Update dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
nvborisenko Sep 28, 2024
063cf0f
Update dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
nvborisenko Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Net.Http.Headers;
Expand Down Expand Up @@ -417,7 +418,11 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
var responseTask = base.SendAsync(request, cancellationToken);

StringBuilder requestLogMessageBuilder = new();
requestLogMessageBuilder.AppendFormat(">> {0}", request);
requestLogMessageBuilder.AppendFormat(">> {0} RequestUri: {1}, Content: {2}, Headers: {3}",
request.Method,
request.RequestUri?.ToString() ?? "null",
request.Content?.ToString() ?? "null",
request.Headers?.Count());

if (request.Content != null)
{
Expand All @@ -430,7 +435,7 @@ protected override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage
var response = await responseTask.ConfigureAwait(false);

StringBuilder responseLogMessageBuilder = new();
responseLogMessageBuilder.AppendFormat("<< {0}", response);
responseLogMessageBuilder.AppendFormat("<< StatusCode: {0}, ReasonPhrase: {1}, Content: {2}, Headers: {3}", (int)response.StatusCode, response.ReasonPhrase, response.Content, response.Headers?.Count());

if (!response.IsSuccessStatusCode && response.Content != null)
{
Expand Down
Loading