[grid]: Capabilities prefix starts with se:slotMatcher for DefaultSlotMatcher decision #14583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qodo-merge-pro
bot
added
P-bug fix
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
VietND96
changed the title
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit 0973487)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
…tMatcher decision Signed-off-by: Viet Nguyen Duc <[email protected]>
VietND96
force-pushed
the
custom-caps-for-slotMatcher
branch
from
deb369a to
0973487
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #14583 +/- ##
==========================================
- Coverage 58.48% 57.78% -0.70%
==========================================
Files 86 89 +3
Lines 5270 5609 +339
Branches 220 245 +25
==========================================
+ Hits 3082 3241 +159
- Misses 1968 2123 +155
- Partials 220 245 +25 ☔ View full report in Codecov by Sentry. |
diemol
reviewed
Oct 10, 2024
|
I am closing this PR, since this implementation is redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Fixes #14576
Grid supports Setting custom capabilities for matching specific Nodes.
However, recently, this feat hasn't worked anymore. It could be due to a few capabilities (e.g:
networkname:applicationName,nodename:applicationName) getting filtered (not meeting standards or something else) before coming to DefaultSlotMatcher.Via a fix recently #14323. All caps that start with the prefix
se:are retained in the session response.Cap name contains
se:is generic for many purposes, and those are also excluded in slot matcher decision as current implementation.So, to make the feat custom caps for matching specific Nodes works, we will dedicate a prefix
se:slotMatcher, for any cap name starts with this prefix will be used in DefaultSlotMatcher decision.Also, it could be similar to #14323, adding an end-to-end test for this is tricky.
Types of changes
Checklist