Skip to content

Throw Error When Using Unsupported Linux ARM #14616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Throw Error When Using Unsupported Linux ARM #14616

Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
25e3bfe
Throw Error When Using Unsupported Linux ARM
shbenzer Oct 17, 2024
378328a
Merge branch 'trunk' into issue-13793
shbenzer Oct 17, 2024
eddc986
Update SeleniumManager.java
shbenzer Oct 17, 2024
04f04c5
fixed formatting
shbenzer Oct 18, 2024
d965ca5
Merge branch 'trunk' into issue-13793
shbenzer Oct 18, 2024
c69505f
Merge branch 'trunk' into issue-13793
shbenzer Oct 22, 2024
a7be622
fixed formatting - my bad
shbenzer Oct 22, 2024
cb89f97
Update SeleniumManager.java
shbenzer Oct 22, 2024
37cd813
Update SeleniumManager.java
shbenzer Oct 22, 2024
c853c84
Merge branch 'trunk' into issue-13793
shbenzer Oct 23, 2024
bbe46a1
Update SeleniumManager.java
shbenzer Oct 23, 2024
8a000fd
Merge branch 'trunk' into issue-13793
shbenzer Oct 25, 2024
40a0b7d
Merge branch 'trunk' into issue-13793
shbenzer Oct 26, 2024
cd16d30
Merge branch 'trunk' into issue-13793
shbenzer Oct 30, 2024
efa1e18
Merge branch 'trunk' into issue-13793
shbenzer Nov 1, 2024
99468b5
Merge branch 'trunk' into issue-13793
pujagani Nov 6, 2024
197f1e7
Merge branch 'trunk' into issue-13793
VietND96 Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion java/src/org/openqa/selenium/manager/SeleniumManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,11 @@ private synchronized Path getBinary() {
} else if (current.is(MAC)) {
folder = "macos";
} else if (current.is(LINUX)) {
folder = "linux";
if (System.getProperty("os.arch").contains("arm")) {
Copy link
Contributor

@mkurz mkurz Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check for aarch64, see

Copy link
Contributor Author

@shbenzer shbenzer Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue and we’d be happy to take a look - commenting here will cause us to miss or forget @mkurz

Copy link
Contributor

@mkurz mkurz Oct 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I referenced the PR I created. I just wanted to make the author of the PR aware that the check was not enough. (Also for readers who stumple on this issue later)

Copy link
Contributor Author

@shbenzer shbenzer Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see - I didn't understand the link clearly on my phone. Thank you!

throw new WebDriverException("Linux ARM is not supported by Selenium Manager");
} else {
folder = "linux";
}
} else if (current.is(UNIX)) {
LOG.warning(
String.format(
Expand Down