-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Address non-JSON trimming warnings #14636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
RenderMichael
wants to merge
3
commits into
SeleniumHQ:trunk
from
RenderMichael:trimming-improvement
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using System.Reflection; | ||
|
|
||
| namespace OpenQA.Selenium.DevTools | ||
|
|
@@ -33,14 +34,23 @@ public abstract class DevToolsDomains | |
| // This is the list of known supported DevTools version implementation. | ||
| // When new versions are implemented for support, new types must be | ||
| // added to this dictionary. | ||
| private static readonly Dictionary<int, Type> SupportedDevToolsVersions = new Dictionary<int, Type>() | ||
| private static readonly Dictionary<int, DomainType> SupportedDevToolsVersions = new Dictionary<int, DomainType>() | ||
| { | ||
| { 127, typeof(V127.V127Domains) }, | ||
| { 129, typeof(V129.V129Domains) }, | ||
| { 128, typeof(V128.V128Domains) }, | ||
| { 85, typeof(V85.V85Domains) } | ||
| { 127, new DomainType(typeof(V127.V127Domains)) }, | ||
| { 129, new DomainType(typeof(V129.V129Domains) )}, | ||
| { 128, new DomainType(typeof(V128.V128Domains) )}, | ||
| { 85, new DomainType(typeof(V85.V85Domains)) }, | ||
| }; | ||
|
|
||
| /// <summary>Workaround for trimming.</summary> | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the kind of workaround necessary when using a |
||
| struct DomainType | ||
| { | ||
| [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] | ||
| public Type Type; | ||
|
|
||
| public DomainType([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] Type t) => Type = t; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the version-specific domains for the DevTools session. This value must be cast to a version specific type to be at all useful. | ||
| /// </summary> | ||
|
|
@@ -102,12 +112,13 @@ public static DevToolsDomains InitializeDomains(int protocolVersion, DevToolsSes | |
| return domains; | ||
| } | ||
|
|
||
| [return: DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] | ||
| private static Type MatchDomainsVersion(int desiredVersion, int versionRange) | ||
| { | ||
| // Return fast on an exact match | ||
| if (SupportedDevToolsVersions.ContainsKey(desiredVersion)) | ||
| if (SupportedDevToolsVersions.TryGetValue(desiredVersion, out DomainType type)) | ||
| { | ||
| return SupportedDevToolsVersions[desiredVersion]; | ||
| return type.Type; | ||
| } | ||
|
|
||
| // Get the list of supported versions and sort descending | ||
|
|
@@ -121,7 +132,7 @@ private static Type MatchDomainsVersion(int desiredVersion, int versionRange) | |
| // (that is, closest without going over). | ||
| if (desiredVersion >= supportedVersion && desiredVersion - supportedVersion < versionRange) | ||
| { | ||
| return SupportedDevToolsVersions[supportedVersion]; | ||
| return SupportedDevToolsVersions[supportedVersion].Type; | ||
| } | ||
| } | ||
|
|
||
|
|
||
12 changes: 9 additions & 3 deletions
12
dotnet/src/webdriver/DevTools/Json/JsonEnumMemberConverter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.