-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[java]: mark WebElement.getAttribute deprecated #14666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! @Delta456
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Marks
WebElement.getAttributeas deprecatedMotivation and Context
Discussed in #13334
Types of changes
Checklist
PR Type
Enhancement
Description
WebElement.getAttributemethod by adding the@Deprecatedannotation.getDomAttributeandgetDomPropertymethods introduced in Selenium 4.getAttributein the future.Changes walkthrough 📝
WebElement.java
Deprecate `getAttribute` method in WebElement interfacejava/src/org/openqa/selenium/WebElement.java
getAttributemethod as deprecated.@Deprecatedannotation to thegetAttributemethod.