- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.6k
 
[rb] Relax base64 dependency version constraint #14678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
[rb] Relax base64 dependency version constraint #14678
Conversation
          PR Reviewer Guide 🔍Here are some key observations to aid the review process: 
  | 
    
          PR Code Suggestions ✨Explore these optional code suggestions: 
 
  | 
    
57a4e8f    to
    78123a6      
    Compare
  
    758fbbb    to
    31da166      
    Compare
  
    | 
           @chileung-b4b could you fix the conflicts? thank you so much!  | 
    
a0cb596    to
    184d940      
    Compare
  
    Version 0.2.0 of base64 has no functional differences with previous versions and some gems still require a previous version of base64.
184d940    to
    572ee8c      
    Compare
  
    
User description
Description
Relax the selenium-webdriver gem dependency on base64 version constraint, including previous versions down to
v0.1.1Motivation and Context
To be able to specify the webdriver binary path i.e
SE_CHROMEDRIVERenvironment variable, we want to use the4.25.0version at least of the gem which includes these changesVersion
v0.2.0of base64 has no functional differences with previous versions and some gems still require a previous version of base64.Sometimes it's hard and/or time consuming to update the other gems depending on a specific base64 version and as both
v0.1.1,v0.1.2andv0.2.0have no functional differences, I think selenium-webdriver should allow using a lower version of base64:Types of changes
Checklist
PR Type
Bug fix, Enhancement
Description
base64gem dependency version inselenium-webdriver.gemspecto allow versions from0.1.1to below0.3.base64, while maintaining functionality.base64versions without functional differences.PRDescriptionHeader.CHANGES_WALKTHROUGH
selenium-webdriver.gemspec
Relax base64 dependency version constraintsrb/selenium-webdriver.gemspec
base64dependency.~> 0.2to allowing versions>= 0.1.1and< 0.3.