Skip to content

[rb] Deprecate CDP methods on Firefox #14763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2024
Merged

[rb] Deprecate CDP methods on Firefox #14763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02187c6
Deprecate CDP for firefox
aguspe Nov 15, 2024
6105a3f
Merge branch 'trunk' into rb_deprecate_firefox_cdp
aguspe Nov 21, 2024
cf16ad7
Make the deprecation message less generic
aguspe Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions rb/lib/selenium/webdriver/common/driver_extensions/has_log_events.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ module HasLogEvents
#

def on_log_event(kind, &block)
if browser == :firefox
WebDriver.logger.deprecate(
'Driver#on_log_event on Firefox',
'the script.add_console_message_handler or the script.add_javascript_error_handler methods',
id: :on_log_event
)
end
raise Error::WebDriverError, "Don't know how to handle #{kind} events" unless KINDS.include?(kind)

enabled = log_listeners[kind].any?
Expand Down
7 changes: 7 additions & 0 deletions rb/lib/selenium/webdriver/common/driver_extensions/has_network_interception.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ module HasNetworkInterception
#

def intercept(&)
if browser == :firefox
WebDriver.logger.deprecate(
'Driver#intercept on Firefox',
'the new bidi.network.add_intercept method',
id: :intercept
)
end
@interceptor ||= DevTools::NetworkInterceptor.new(devtools)
@interceptor.intercept(&)
end
Expand Down
Loading