-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Align webdriver errors with spec #14936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
736154e
[dotnet] Remove out-of-spec `UnhandledError` error status
RenderMichael fddbd4e
Merge branch 'trunk' into unhandled-error
RenderMichael 46eea55
Align webdriver errors with spec, mitigate breaking change
RenderMichael cea0ced
Merge branch 'unhandled-error' of https://github.com/RenderMichael/se…
RenderMichael 1a6e524
Merge branch 'trunk' into unhandled-error
RenderMichael 8d5e095
Merge branch 'trunk' into unhandled-error
RenderMichael 2e2fe67
Merge branch 'trunk' into unhandled-error
RenderMichael dffd894
Obsolete webdriver results that W3C spec no longer returns
RenderMichael a603fc5
Merge branch 'unhandled-error' of https://github.com/RenderMichael/se…
RenderMichael 0914067
Add obsoletion to `NoSuchDocument` as well
RenderMichael bd62f6f
remove extra period in XML doc
RenderMichael a14ea4b
Update obsoletion message for unused webdriver results
RenderMichael edb9967
Remove mapping to obsolete webdriver errors, obsolete public-facing m…
RenderMichael f3c253e
remove TODO
RenderMichael 137eecb
Remove not-actually-public strings
RenderMichael 36f4a47
Add removal version to obsoletion messages
RenderMichael 11ceeed
remove accidental push
RenderMichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // <copyright file="UnknownErrorException.cs" company="Selenium Committers"> | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| // </copyright> | ||
|
|
||
| using System; | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace OpenQA.Selenium | ||
| { | ||
| /// <summary> | ||
| /// An unknown error occurred in the remote end while processing the command. | ||
| /// </summary> | ||
| [Serializable] | ||
| public class UnknownErrorException : WebDriverException | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnknownErrorException"/> class with the specified message. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| public UnknownErrorException(string? message) | ||
| : base(message) | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnknownErrorException"/> class with the specified message and inner exception. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| /// <param name="innerException">The inner exception for this exception.</param> | ||
| public UnknownErrorException(string? message, Exception? innerException) | ||
| : base(message, innerException) | ||
| { | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| // <copyright file="UnknownMethodException.cs" company="Selenium Committers"> | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| // </copyright> | ||
|
|
||
| using System; | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace OpenQA.Selenium | ||
| { | ||
| /// <summary> | ||
| /// Exception that is thrown when the requested command matched a known URL but did not match any method for that URL. | ||
| /// </summary> | ||
| [Serializable] | ||
| public class UnknownMethodException : WebDriverException | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnknownMethodException"/> class with the specified message. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| public UnknownMethodException(string? message) : base(message) | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnknownMethodException"/> class with the specified message and inner exception. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| /// <param name="innerException">The inner exception for this exception.</param> | ||
| public UnknownMethodException(string? message, Exception? innerException) : base(message, innerException) | ||
| { | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // <copyright file="UnsupportedOperationException.cs" company="Selenium Committers"> | ||
| // Licensed to the Software Freedom Conservancy (SFC) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The SFC licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| // </copyright> | ||
|
|
||
| using System; | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace OpenQA.Selenium | ||
| { | ||
| /// <summary> | ||
| /// Indicates that a command that should have executed properly cannot be supported for some reason. | ||
| /// </summary> | ||
| public class UnsupportedOperationException : WebDriverException | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnsupportedOperationException"/> class with the specified message. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| public UnsupportedOperationException(string? message) | ||
| : base(message) | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="UnsupportedOperationException"/> class with the specified message and inner exception. | ||
| /// </summary> | ||
| /// <param name="message">The message of the exception.</param> | ||
| /// <param name="innerException">The inner exception for this exception.</param> | ||
| public UnsupportedOperationException(string? message, Exception? innerException) | ||
| : base(message, innerException) | ||
| { | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.