Skip to content

Fix exception traceback to omit superfluous 'Backtrace' information #14975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix exception traceback to omit superfluous 'Backtrace' information #14975

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f859be1
Fix exception traceback to omit superfluous 'Backtrace' information
SmartManoj Dec 29, 2024
789368a
Discard changes to py/selenium/webdriver/remote/errorhandler.py
SmartManoj Dec 29, 2024
b795a00
Merge branch 'trunk' into fix-exception-traceback
SmartManoj Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion py/selenium/common/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

from typing import Optional
from typing import Sequence
import os

SUPPORT_MSG = "For documentation on this error, please visit:"
ERROR_URL = "https://www.selenium.dev/documentation/webdriver/troubleshooting/errors"
Expand All @@ -38,7 +39,7 @@ def __str__(self) -> str:
exception_msg = f"Message: {self.msg}\n"
if self.screen:
exception_msg += "Screenshot: available via screen\n"
if self.stacktrace:
if self.stacktrace and os.getenv("INCLUDE_STACKTRACE"):
Copy link
Author

@SmartManoj SmartManoj Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if self.stacktrace and os.getenv("INCLUDE_STACKTRACE"):
if self.stacktrace and not os.getenv("EXCLUDE_STACKTRACE"):

Will this change be accepted?

stacktrace = "\n".join(self.stacktrace)
exception_msg += f"Stacktrace:\n{stacktrace}"
return exception_msg
Expand Down