- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.6k
 
[grid] Dynamic Grid is able to trigger video record in browser node #15047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          PR Reviewer Guide 🔍Here are some key observations to aid the review process: 
  | 
    
          PR Code Suggestions ✨Explore these optional code suggestions: 
  | 
    
          CI Failure Feedback 🧐(Checks updated until commit b20c9aa)
 ✨ CI feedback usage guide:The CI feedback tool ( 
 In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where  Configuration options
 See more information about the   | 
    
5302ad4    to
    45a6759      
    Compare
  
    Signed-off-by: Viet Nguyen Duc <[email protected]>
…eleniumHQ#15047) Signed-off-by: Viet Nguyen Duc <[email protected]>
…eleniumHQ#15047) Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #14757
--docker-video-image falsese:recordVideo=true, the recording in the browser node can be triggered itself (details of the implementation is explained in Enable video recorder in Node/Standalone containers docker-selenium#2539)If users want to use the previous approach for recording (backward compatible). Set below config
In TOML config
In CLI option
--docker-video-image "selenium/video:latest"Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Added ability to disable video container in Dynamic Grid.
Modified
DockerOptionsto handlefalsevideo-image configuration.Updated
DockerSessionFactoryto check for null video image before starting.Enhanced video container logic for better configurability.
Changes walkthrough 📝
DockerOptions.java
Handle disabling video container in DockerOptionsjava/src/org/openqa/selenium/grid/node/docker/DockerOptions.java
getVideoImageto handlefalseconfiguration.DockerSessionFactory.java
Update video container start logic in DockerSessionFactoryjava/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java