-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Fix logging issue when log context level conflicts with logger already captured level #15057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nvborisenko
merged 11 commits into
SeleniumHQ:trunk
from
nvborisenko:dotnet-logging-issue
Jan 10, 2025
Merged
[dotnet] Fix logging issue when log context level conflicts with logger already captured level #15057
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
636b523
Add test to highlight the issue with captured log level by logger
nvborisenko 55027c3
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging-issue
nvborisenko 029d0d6
Merge remote-tracking branch 'upstream/trunk' into dotnet-logging-issue
nvborisenko dae7454
Determine IsEnabled across local loggers
nvborisenko 77e8a05
Loggers per context
nvborisenko 7250bbf
Merge branch 'trunk' into dotnet-logging-issue
nvborisenko e3d1ba1
Fix possible NRE
nvborisenko df09141
Convert to TryGetValue
nvborisenko 6efac84
Move logic to clone loggers
nvborisenko 437594e
Merge branch 'trunk' into dotnet-logging-issue
nvborisenko 5057ec0
Clone in CreateContext method
nvborisenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.