Use tax.xz for Firefox package starting in version 135 in pinned browsers

[DineshKumarRA]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Use tax.xz for Firefox package starting in version 135 in pinned browsers. The changes should fix the issue with pinned browsers and drivers PR.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix

---

Description

• Updated Firefox Linux package URL logic for version 135 and above.

• Ensured compatibility with .tar.xz format for newer Firefox versions.

---

Changes walkthrough 📝

	Relevant files
Bug fix	pinned_browsers.py Adjusted Firefox Linux URL logic for version 135+                scripts/pinned_browsers.py Modified firefox_linux function to handle version-specific URL logic. Added conditional check for Firefox versions below and above 135. Updated URL format to .tar.xz for versions 135 and above. +6/-1

---

Need help?

Type /help how to ... in the comments thread for any question about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Version Parsing The version parsing assumes the version string can be split by dot and the first component is numeric. This may fail for non-standard version strings. if int(version.split(".")[0]) < 135:

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add version parsing error handling Add error handling for version parsing to prevent crashes when version string is malformed or empty scripts/pinned_browsers.py [419] -if int(version.split(".")[0]) < 135: +if not version or not version.strip(): + raise ValueError("Firefox version cannot be empty") +try: + major_version = int(version.split(".")[0]) + if major_version < 135: Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion adds crucial error handling for version parsing, preventing potential runtime crashes when dealing with malformed version strings. This is important for application stability and better error reporting.	8
General	Reduce URL string duplication Use string formatting with a common URL template to reduce code duplication and potential maintenance issues scripts/pinned_browsers.py [419-424] -if int(version.split(".")[0]) < 135: - return "https://ftp.mozilla.org/pub/firefox/releases/%s/linux-x86_64/en-US/firefox-%s.tar.bz2" % ( - version, version) -else: - return "https://ftp.mozilla.org/pub/firefox/releases/%s/linux-x86_64/en-US/firefox-%s.tar.xz" % ( - version, version) +extension = "tar.bz2" if int(version.split(".")[0]) < 135 else "tar.xz" +return f"https://ftp.mozilla.org/pub/firefox/releases/{version}/linux-x86_64/en-US/firefox-{version}.{extension}" Apply this suggestion Suggestion importance[1-10]: 7 Why: The suggestion effectively reduces code duplication by using a common URL template and f-strings, making the code more maintainable and less prone to errors when URL patterns need to be updated.	7

[DineshKumarRA]

@diemol @VietND96 This PR should fix the issue with 'Automated Browser Version Update' PR's

[VietND96]

Thank you for the fix!