- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8.6k
[java] Add nullness for interactions #15118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| PR Reviewer Guide 🔍Here are some key observations to aid the review process: 
 | 
| PR Code Suggestions ✨Explore these optional code suggestions: 
 | 
| Fixed NullAway error:  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @mk868
| Thank you! @mk868 | 
User description
Description
In this PR I'm adding nullness annotations for classes:
org.openqa.selenium.interactions.Coordinatesorg.openqa.selenium.interactions.Interactiveorg.openqa.selenium.interactions.SourceType- I also changednullto"none"as descried in the w3.org, this change should be safe to apply becauseSourceType.NONEhas no uses in the code.NullAway analysis: #14421
Motivation and Context
The JSpecify nullness annotations will give developers better exposure to potential problems with their code to avoid NullPointerExceptions.
Related issue: #14291
Types of changes
Checklist
PR Type
Enhancement
Description
Added JSpecify
@NullMarkedannotations to improve nullness handling.Updated
SourceType.NONEvalue fromnullto"none"for compliance.Enhanced IDE and static analysis support for nullability.
Changes walkthrough 📝
Coordinates.java
Add `@NullMarked` annotation to `Coordinates`java/src/org/openqa/selenium/interactions/Coordinates.java
@NullMarkedannotation to theCoordinatesinterface.Interactive.java
Add `@NullMarked` annotation to `Interactive`java/src/org/openqa/selenium/interactions/Interactive.java
@NullMarkedannotation to theInteractiveinterface.SourceType.java
Add `@NullMarked` annotation and update `SourceType.NONE`java/src/org/openqa/selenium/interactions/SourceType.java
@NullMarkedannotation to theSourceTypeenum.SourceType.NONEvalue fromnullto"none".