Skip to content

[grid] Grid UI could not open session live view #15132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025
Merged

[grid] Grid UI could not open session live view #15132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
667696b
[grid] Grid UI could not open session live view
VietND96 Jan 22, 2025
c6d5562
Bump version 4.28.1 for java and update changelog
VietND96 Jan 22, 2025
02f1f4a
Merge branch 'trunk' into fix-novnc
VietND96 Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java/CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
v4.28.1
======
* [java]: Add Locale.ROOT to avoid port formatting issues for all drivers (#15121)
* [grid]: Grid UI could not open session live view (#15132)

v4.28.0
======
* Add CDP for Chrome 132 and remove 129
Expand Down
2 changes: 1 addition & 1 deletion java/version.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
SE_VERSION = "4.29.0-SNAPSHOT"
SE_VERSION = "4.28.1"
TOOLS_JAVA_VERSION = "17"
3 changes: 2 additions & 1 deletion javascript/grid-ui/src/components/LiveView/LiveView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,13 @@ const LiveView = forwardRef((props, ref) => {
return
}

const newRfb = new RFB(canvas, props.url, {})
const newRfb = new RFB.default(canvas, props.url, {})
newRfb.scaleViewport = props.scaleViewport
newRfb.background = 'rgb(247,248,248)'
newRfb.addEventListener('credentialsrequired', handleCredentials)
newRfb.addEventListener('securityfailure', securityFailed)
newRfb.addEventListener('connect', connectedToServer)
newRfb.addEventListener('disconnect', disconnect)
setRfb(newRfb)
}

Expand Down
Loading