-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] [bidi] Add network SetCacheBehavior command #15133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] [bidi] Add network SetCacheBehavior command #15133
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs
Show resolved
Hide resolved
RenderMichael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
User description
Description
Expanding BiDi coverage in .NET
Motivation and Context
Fixes #14532
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added
SetCacheBehaviorcommand to the Network module in .NET BiDi.Implemented
SetCacheBehaviorCommandand related parameters and options.Updated
BrowsingContextNetworkModuleandNetworkModuleto support cache behavior configuration.Added unit tests to validate
SetCacheBehaviorfunctionality.Changes walkthrough 📝
Command.cs
Register `SetCacheBehaviorCommand` in command typesdotnet/src/webdriver/BiDi/Communication/Command.cs
SetCacheBehaviorCommandas a derived type for networkcommands.
BrowsingContextNetworkModule.cs
Add `SetCacheBehaviorAsync` to BrowsingContextNetworkModuledotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs
SetCacheBehaviorAsyncmethod to configure cache behavior.SetCacheBehaviorOptionsfor browsing context.NetworkModule.cs
Implement `SetCacheBehaviorAsync` in NetworkModuledotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.cs
SetCacheBehaviorAsyncmethod inNetworkModule.SetCacheBehaviorCommandParametersand options.SetCacheBehaviorCommand.cs
Add `SetCacheBehaviorCommand` and related classesdotnet/src/webdriver/BiDi/Modules/Network/SetCacheBehaviorCommand.cs
SetCacheBehaviorCommandclass and parameters.SetCacheBehaviorOptionsandCacheBehaviorenum.NetworkTest.cs
Add unit tests for `SetCacheBehavior`dotnet/test/common/BiDi/Network/NetworkTest.cs
SetCacheBehaviorfunctionality.