-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Add nullability to Command type
#15147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
* [dotnet] Add nullability to `Command` type * Simplify initialization logic of `Command.Parameters`
* [dotnet] Add nullability to `Command` type * Simplify initialization logic of `Command.Parameters`
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add nullability to
CommandtypeMotivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Added nullability annotations to the
Commandclass.Refactored properties to use auto-implemented properties.
Updated method
ConvertParametersFromJsonto handle null and exceptions.Improved code readability and consistency in
Commandclass.Changes walkthrough 📝
Command.cs
Refactored and added nullability to `Command` classdotnet/src/webdriver/Command.cs
ConvertParametersFromJsonto handle null and exceptions.