-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] Add PrintOptions Implementation for Ruby WebDriver #15158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5b49c62
Implement print_options to support default, predefined, and custom pa…
yvsvarma ca06ef2
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma bc75924
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 20f3797
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 01650fd
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 25b0a23
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma e7091d4
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 2ce2b06
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 997a338
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 6bd449d
[rb] Add PrintOptions class with support for predefined and custom pa…
yvsvarma 4ca0796
Support custom and predefined page sizes in PrintOptions; update tests
yvsvarma 5e20f5d
Support custom and predefined page sizes in PrintOptions; update tests
yvsvarma 8cca40e
Remove unnecessary spec_helper.rb as per review feedback
yvsvarma 6f6437f
Remove unnecessary spec_helper.rb as per review feedback
yvsvarma 369b31e
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma acbc792
Add support for setting page size in Ruby PrintOptions
yvsvarma f376af3
adding copyright text in print_options_spec.rb
yvsvarma 428922d
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 93672f3
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 19f051f
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma 6297d5f
fixing the format errors
yvsvarma 46259f9
Merge branch 'trunk' into ruby-pagesize-support
yvsvarma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| # <copyright file="print_options.rb" company="Selenium Committers"> | ||
| # Licensed to the Software Freedom Conservancy (SFC) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The SFC licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # </copyright> | ||
|
|
||
| module Selenium | ||
| module WebDriver | ||
| # Represents options for printing a page. | ||
| class PrintOptions | ||
| DEFAULT_SCALE = 1.0 | ||
| DEFAULT_ORIENTATION = 'portrait'.freeze | ||
| DEFAULT_PAGE_SIZE = {width: 21.0, height: 29.7}.freeze # A4 size in cm | ||
| DEFAULT_MARGINS = {top: 1.0, bottom: 1.0, left: 1.0, right: 1.0}.freeze | ||
|
|
||
| attr_accessor :orientation, :scale, :background, :page_ranges, :page_size, :margins | ||
|
|
||
| def initialize | ||
| @orientation = DEFAULT_ORIENTATION | ||
| @scale = DEFAULT_SCALE | ||
| @background = false | ||
| @page_ranges = nil | ||
| @page_size = DEFAULT_PAGE_SIZE | ||
| @margins = DEFAULT_MARGINS | ||
| end | ||
|
|
||
| # Converts the options to a hash format to be used by WebDriver. | ||
| # | ||
| # @return [Hash] | ||
| def to_h | ||
| options = { | ||
| orientation: @orientation, | ||
| scale: @scale, | ||
| background: @background, | ||
| pageRanges: @page_ranges, | ||
| paperWidth: @page_size[:width], | ||
| paperHeight: @page_size[:height], | ||
| marginTop: @margins[:top], | ||
| marginBottom: @margins[:bottom], | ||
| marginLeft: @margins[:left], | ||
| marginRight: @margins[:right] | ||
| } | ||
|
|
||
| options.compact | ||
| end | ||
|
|
||
| # Sets the page size to a predefined size. | ||
| # | ||
| # @param [Symbol] size The predefined size (:letter, :legal, :a4, :tabloid). | ||
| def set_page_size(size) | ||
| predefined_sizes = { | ||
| letter: {width: 21.59, height: 27.94}, | ||
| legal: {width: 21.59, height: 35.56}, | ||
| a4: {width: 21.0, height: 29.7}, | ||
| tabloid: {width: 27.94, height: 43.18} | ||
| } | ||
|
|
||
| raise ArgumentError, "Invalid page size: #{size}" unless predefined_sizes.key?(size) | ||
|
|
||
| @page_size = predefined_sizes[size] | ||
| end | ||
| end | ||
| end | ||
| end | ||
p0deje marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| $LOAD_PATH.unshift File.expand_path('../../lib', __dir__) | ||
| require 'rspec' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| # Licensed to the Software Freedom Conservancy (SFC) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The SFC licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| # frozen_string_literal: true | ||
|
|
||
| require_relative '../../spec_helper' | ||
| require 'selenium/webdriver/common/print_options' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
require File.expand_path('../spec_helper', __dir__)
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Addressed Review Comments
Thank you for reviewing @p0deje |
||
|
|
||
|
|
||
| module Selenium | ||
| module WebDriver | ||
| describe PrintOptions do | ||
| let(:options) { PrintOptions.new } | ||
|
|
||
| it 'has default values' do | ||
| expect(options.orientation).to eq('portrait') | ||
| expect(options.scale).to eq(1.0) | ||
| expect(options.background).to be(false) | ||
| expect(options.page_size).to eq({ width: 21.0, height: 29.7 }) | ||
| expect(options.margins).to eq({ top: 1.0, bottom: 1.0, left: 1.0, right: 1.0 }) | ||
| end | ||
|
|
||
| it 'can set custom page size' do | ||
| custom_size = { width: 25.0, height: 30.0 } | ||
| options.page_size = custom_size | ||
| expect(options.page_size).to eq(custom_size) | ||
| end | ||
|
|
||
| it 'can set predefined page sizes' do | ||
| options.set_page_size(:a4) | ||
| expect(options.page_size).to eq({ width: 21.0, height: 29.7 }) | ||
|
|
||
| options.set_page_size(:legal) | ||
| expect(options.page_size).to eq({ width: 21.59, height: 35.56 }) | ||
|
|
||
| options.set_page_size(:tabloid) | ||
| expect(options.page_size).to eq({ width: 27.94, height: 43.18 }) | ||
|
|
||
| options.set_page_size(:letter) | ||
| expect(options.page_size).to eq({ width: 21.59, height: 27.94 }) | ||
| end | ||
|
|
||
| it 'raises an error for invalid page size' do | ||
| expect { options.set_page_size(:invalid) }.to raise_error(ArgumentError, /Invalid page size/) | ||
| end | ||
|
|
||
| it 'can convert to a hash' do | ||
| options.scale = 0.5 | ||
| options.background = true | ||
| options.page_ranges = '1-3' | ||
| hash = options.to_h | ||
|
|
||
| expect(hash).to eq( | ||
| { | ||
| orientation: 'portrait', | ||
| scale: 0.5, | ||
| background: true, | ||
| pageRanges: '1-3', | ||
| paperWidth: 21.0, | ||
| paperHeight: 29.7, | ||
| marginTop: 1.0, | ||
| marginBottom: 1.0, | ||
| marginLeft: 1.0, | ||
| marginRight: 1.0 | ||
| } | ||
| ) | ||
| end | ||
| end | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.