Skip to content

[dotnet] Improve bidi exception when it is not enabled #15163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[dotnet] Improve bidi exception when it is not enabled #15163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
588bc7d
[dotnet] Improve bidi exception when it is not enabled
nvborisenko Jan 26, 2025
875e1d8
Avoid InvalidCastException and guard for null
nvborisenko Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
// </copyright>

using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
using System;
using System.Threading.Tasks;

#nullable enable
Expand All @@ -28,11 +29,18 @@ public static class WebDriverExtensions
{
public static async Task<BiDi> AsBiDiAsync(this IWebDriver webDriver)
{
var webSocketUrl = ((IHasCapabilities)webDriver).Capabilities.GetCapability("webSocketUrl");
if (webDriver is null) throw new ArgumentNullException(nameof(webDriver));

if (webSocketUrl is null) throw new System.Exception("The driver is not compatible with bidirectional protocol or it is not enabled in driver options.");
string? webSocketUrl = null;

var bidi = await BiDi.ConnectAsync(webSocketUrl.ToString()!).ConfigureAwait(false);
if (webDriver is IHasCapabilities hasCapabilities)
{
webSocketUrl = hasCapabilities.Capabilities.GetCapability("webSocketUrl")?.ToString();
}

if (webSocketUrl is null) throw new BiDiException("The driver is not compatible with bidirectional protocol or \"webSocketUrl\" not enabled in driver options.");

var bidi = await BiDi.ConnectAsync(webSocketUrl).ConfigureAwait(false);

return bidi;
}
Expand Down
Loading