-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Source-generate CDP command and response serialization #15172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cc259b8
[dotnet] Source-generate CDP commands and responses
RenderMichael 1342641
Align with usual JSON serializer style
RenderMichael 7f122e8
fix build
RenderMichael cfa5401
Separate DevTools JSON serialization context per domain
RenderMichael c17accc
Fix formatting
RenderMichael e92ac14
Move DevTools JSON context to each adapter
RenderMichael f960916
Revert DevTools JSON handling by domains
RenderMichael 32bd65a
remove unused usings
RenderMichael 35439c4
Remove IAdapter experiment
RenderMichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
dotnet/src/webdriver/DevTools/Json/CdpJsonSerializationContext.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| using System.Text.Json.Serialization; | ||
|
|
||
| namespace OpenQA.Selenium.DevTools.Json; | ||
|
|
||
| [JsonSerializable(typeof(ICommand))] | ||
| [JsonSerializable(typeof(ICommandResponse<>))] | ||
| [JsonSourceGenerationOptions(Converters = [typeof(StringConverter)])] | ||
| internal sealed partial class CdpSerializationContext : JsonSerializerContext; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 2 options:
CdpSerializationContextfor types from all cdp namespaces (v130, v131, v132) (and we know how to resolve collisions)I am not deep dived yet. Please suggest which option would be more friendly for us.