Skip to content

[dotnet] Annotate nullability on FirefoxDriverService #15220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2025
Merged

[dotnet] Annotate nullability on FirefoxDriverService #15220

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed41246
[dotnet] Annotate nullability on `FirefoxDriverService`
RenderMichael Feb 3, 2025
0d4fdc5
Replace null suppress with exception
RenderMichael Feb 3, 2025
a29331e
Bring back null suppression
RenderMichael Feb 3, 2025
8c1135b
Merge branch 'trunk' into ff-driver-service
RenderMichael Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/Firefox/FirefoxDriverService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public static FirefoxDriverService CreateDefaultService(string driverPath)
if (File.Exists(driverPath))
{
fileName = Path.GetFileName(driverPath);
driverPath = Path.GetDirectoryName(driverPath)!;
driverPath = Path.GetDirectoryName(driverPath) ?? throw new ArgumentException("Driver file exists but parent directory is unreachable", nameof(driverPath));
}
else
{
Expand Down
Loading