Skip to content

[dotnet] Simplify and nullable annotate DriverFinder #15232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 28, 2025
Merged

[dotnet] Simplify and nullable annotate DriverFinder #15232

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1b7dfb7
[dotnet] Simplify and nullable annotate `DriverFinder`
RenderMichael Feb 4, 2025
dbe9758
Merge branch 'trunk' into driver-finder
RenderMichael Feb 28, 2025
8e7b8b2
Minimize diffs
RenderMichael Feb 28, 2025
26714e5
Maintain previous logic
RenderMichael Feb 28, 2025
f276b39
Better local name
RenderMichael Feb 28, 2025
b063018
Minimize diffs
RenderMichael Feb 28, 2025
77f35ea
Minimize diffs further
RenderMichael Feb 28, 2025
4914e89
Better code style
RenderMichael Feb 28, 2025
312eab7
Modernate minimal diffs with code style
RenderMichael Feb 28, 2025
02ad8d0
Go back to dictionary style
RenderMichael Feb 28, 2025
defff98
Use more consistent consts
RenderMichael Feb 28, 2025
ac2e3a5
Make name the same
RenderMichael Feb 28, 2025
b349ef4
Use single path
RenderMichael Feb 28, 2025
352750b
minimize more diffs
RenderMichael Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dotnet/src/webdriver/SeleniumManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ internal sealed record SeleniumManagerResponse(IReadOnlyList<LogEntryResponse> L
{
public sealed record LogEntryResponse(string Level, string Message);

internal sealed record ResultResponse
public sealed record ResultResponse
(
[property: JsonPropertyName(SeleniumManager.DriverPathKey)]
string DriverPath,
Expand All @@ -224,7 +224,6 @@ string BrowserPath
);
}


[JsonSerializable(typeof(SeleniumManagerResponse))]
[JsonSourceGenerationOptions(PropertyNameCaseInsensitive = true)]
internal sealed partial class SeleniumManagerSerializerContext : JsonSerializerContext;
Expand Down
Loading