Skip to content

[dotnet][bidi] Remove AsBiDiContextAsync helper to avoid disposal issue #15279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[dotnet][bidi] Remove AsBiDiContextAsync helper to avoid disposal issue #15279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
// under the License.
// </copyright>

using OpenQA.Selenium.BiDi.Modules.BrowsingContext;
using System;
using System.Threading.Tasks;

Expand All @@ -44,13 +43,4 @@ public static async Task<BiDi> AsBiDiAsync(this IWebDriver webDriver)

return bidi;
}

public static async Task<BrowsingContext> AsBiDiContextAsync(this IWebDriver webDriver)
{
var bidi = await webDriver.AsBiDiAsync();

var currentBrowsingContext = new BrowsingContext(bidi, webDriver.CurrentWindowHandle);

return currentBrowsingContext;
}
}
5 changes: 3 additions & 2 deletions dotnet/test/common/BiDi/BiDiFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ public async Task BiDiSetUp()

driver = EnvironmentManager.Instance.CreateDriverInstance(options);

context = await driver.AsBiDiContextAsync();
bidi = context.BiDi;
bidi = await driver.AsBiDiAsync();

context = (await bidi.BrowsingContext.GetTreeAsync())[0].Context;
}

[TearDown]
Expand Down
Loading