Skip to content

[rb] remove guard from working test #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[rb] remove guard from working test #15307

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dece61f
skip test for rubocop
aguspe Feb 18, 2025
bca9af2
Merge branch 'release-preparation-4.29.0' into rb_disable_provide_res…
aguspe Feb 18, 2025
420fc7b
Add github issue to the reason of skipped tests
aguspe Feb 18, 2025
a5b593f
Merge remote-tracking branch 'origin/rb_disable_provide_response_test…
aguspe Feb 18, 2025
1b1bc76
Remove guard
aguspe Feb 18, 2025
ce6a156
Update tests
aguspe Feb 18, 2025
9170462
Guard firefox test
aguspe Feb 18, 2025
e6f110b
Remove guard from working text
aguspe Feb 19, 2025
ad1aef0
Merge branch 'release-preparation-4.29.0' into rb_remove_guard_from_w…
aguspe Feb 19, 2025
9c7772b
Update action_builder_spec.rb
aguspe Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rb/spec/integration/selenium/webdriver/action_builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ module WebDriver
end

describe '#scroll_by' do
it 'scrolls by given amount', except: {browser: :firefox, reason: 'returns false on firefox'} do
it 'scrolls by given amount' do
driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
footer = driver.find_element(tag_name: 'footer')
delta_y = footer.rect.y.round
Expand Down
Loading