Skip to content

[java] Refactored the UsernameAndPassword class to a record #15360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[java] Refactored the UsernameAndPassword class to a record #15360

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6cccaa0
Refactor UsernameAndPassword to use Java record
manuelsblanco Mar 2, 2025
07f128f
[FEAT] Restore factory method and optimize record implementation
manuelsblanco Mar 9, 2025
1e57f88
Merge branch 'trunk' into recordClass
manuelsblanco Mar 12, 2025
9779f68
Merge branch 'trunk' into recordClass
manuelsblanco Mar 14, 2025
f4f1b4e
[FEAT] Newline added by request from @Delta456
manuelsblanco Mar 14, 2025
360f785
Merge branch 'trunk' into recordClass
VietND96 Mar 18, 2025
2ceac19
Merge branch 'trunk' into recordClass
manuelsblanco Mar 20, 2025
a6583b9
Merge branch 'trunk' into recordClass
manuelsblanco Mar 21, 2025
0904700
Merge branch 'trunk' into recordClass
manuelsblanco Mar 23, 2025
8b53174
Merge branch 'trunk' into recordClass
pujagani Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 7 additions & 24 deletions java/src/org/openqa/selenium/UsernameAndPassword.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,36 +17,19 @@

package org.openqa.selenium;

import java.util.function.Supplier;
import org.jspecify.annotations.NullMarked;
import org.openqa.selenium.internal.Require;

/** A combination of username and password to use when authenticating a browser with a website. */
@NullMarked
public class UsernameAndPassword implements Credentials {
public record UsernameAndPassword(String username, String password) implements Credentials {

private final String username;
private final String password;

public UsernameAndPassword(String username, String password) {
this.username = Require.nonNull("User name", username);
this.password = Require.nonNull("Password", password);
}

public static Supplier<Credentials> of(String username, String password) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, note that this method is used by Selenium users, for example:

import org.openqa.selenium.UsernameAndPassword;
import org.openqa.selenium.chrome.ChromeDriver;

public class Main {

  public static void main(String[] args) throws InterruptedException {
    var driver = new ChromeDriver();
    driver.register(UsernameAndPassword.of("foo", "bar"));

    driver.get("http://httpbin.org/basic-auth/foo/bar");

    Thread.sleep(10_000);
    driver.quit();
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mk868 New commit with the new code added. Thanks

Require.nonNull("User name", username);
Require.nonNull("Password", password);

Credentials creds = new UsernameAndPassword(username, password);

return () -> creds;
}

public String username() {
return username;
public UsernameAndPassword {
username = Require.nonNull("User name", username);
password = Require.nonNull("Password", password);
}

public String password() {
return password;
public static UsernameAndPassword of(String username, String password) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. It is changing the function return type.

return new UsernameAndPassword(username, password);
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Delta456 newline added