Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rb/lib/selenium/webdriver/remote/bridge.rb
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ def add_cookie(cookie)
end

def delete_cookie(name)
raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.strip.empty?

execute :delete_cookie, name: name
end

Expand Down
6 changes: 5 additions & 1 deletion rb/spec/integration/selenium/webdriver/manager_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ module WebDriver

it 'deletes one' do
driver.manage.add_cookie name: 'foo', value: 'bar'

driver.manage.delete_cookie('foo')
expect(driver.manage.all_cookies.find { |c| c[:name] == 'foo' }).to be_nil
end
Expand All @@ -253,6 +252,11 @@ module WebDriver
expect { driver.manage.cookie_named('non-existent') }
.to raise_exception(Error::NoSuchCookieError)
end

it 'throws an error when cookie name is an empty string' do
expect { driver.manage.delete_cookie('') }
.to raise_error(ArgumentError, /Cookie name cannot be null or empty/)
end
end
end # Options
end # WebDriver
Expand Down
Loading