Skip to content

[dotnet] [bidi] Align Scipt.LocalValue.Map with spec, enable negative zero #15395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 15, 2025
Merged

[dotnet] [bidi] Align Scipt.LocalValue.Map with spec, enable negative zero #15395

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ae2d622
[dotnet] Align `Scipt.LocalValue.Map` with spec
RenderMichael Mar 9, 2025
bd5aedc
Add test for Set
RenderMichael Mar 9, 2025
50f28b5
Remove obsolete assertion
RenderMichael Mar 9, 2025
9db00ab
Update new test name
RenderMichael Mar 9, 2025
d36e44e
Fix build
RenderMichael Mar 9, 2025
7e279bc
Replace TestCaseSource with individual tests
RenderMichael Mar 9, 2025
a91685b
Allow reading numbers from strings
RenderMichael Mar 9, 2025
83587d8
Separate CallFunction argument and return tests
RenderMichael Mar 10, 2025
9612f5f
Merge branch 'trunk' into bidi-map
RenderMichael Mar 10, 2025
e7a751d
Split tests into more classes
RenderMichael Mar 10, 2025
f51248e
remove unused imports
RenderMichael Mar 10, 2025
5c0f772
Properly serialize negative zero
RenderMichael Mar 10, 2025
d7c58f7
Fix variable name
RenderMichael Mar 10, 2025
45ecae9
fix formatting
RenderMichael Mar 10, 2025
0d8f906
Apply double converter directly to `RemoteValue.Number`
RenderMichael Mar 11, 2025
53310f7
Rename and clean up `DoubleConverter`
RenderMichael Mar 11, 2025
98cafd1
Clarify "is negative zero" check
RenderMichael Mar 11, 2025
6627a82
Merge branch 'trunk' into bidi-map
RenderMichael Mar 11, 2025
6c9c303
fix formatting
RenderMichael Mar 11, 2025
50abe67
Remove `BiDiDoubleConverter`
RenderMichael Mar 12, 2025
79b9274
Ignore failing tests
RenderMichael Mar 12, 2025
0a8d550
fix which tet is disabled
RenderMichael Mar 12, 2025
f2a615e
PR feedback
RenderMichael Mar 12, 2025
8c36bb2
PR feedback
RenderMichael Mar 12, 2025
034b533
Merge branch 'trunk' into bidi-map
RenderMichael Mar 12, 2025
1a7c7f3
PR test feedback
RenderMichael Mar 12, 2025
f4d3785
Rename local
RenderMichael Mar 12, 2025
d46e10f
fix further
RenderMichael Mar 12, 2025
d5c4954
Avoid magic of records for remote primitives
RenderMichael Mar 13, 2025
c51dc4c
Merge branch 'trunk' into bidi-map
RenderMichael Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading