-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] [bidi] Simplify conversion to LocalValue
#15441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ccc536d
[dotnet] [bidi] Simplify usage of `LocalValue`
RenderMichael 0722af5
Update exception
RenderMichael cd55951
Use new methods better in tests
RenderMichael 47891c5
`String(null)` returns `NullLocalValue`
RenderMichael d367a66
Merge branch 'trunk' into local-value
RenderMichael c7cbaf7
Add regex overload that takes a string pattern
RenderMichael 0c4f8bf
Remote static factory methods for now
RenderMichael 6ae7a94
remove unnecessary change
RenderMichael c7ac3b9
Avoid BigInt until we need it
RenderMichael c73fd33
Account for BigInt in ConvertFrom(object)
RenderMichael a762425
Avoid implicit casts in tests that aren't there to test it
RenderMichael 02ace40
Merge branch 'trunk' into local-value
RenderMichael 2ae4fad
Remote `LocalValue.ConvertFrom(JsonNode)`, expand `ConvertFrom(object)`
RenderMichael 49f1347
Merge branch 'trunk' into local-value
RenderMichael e875b05
Add ConvertFrom support for `DateTime` and `long`
RenderMichael 4e6db49
Add unit tests to LocalValue operators
RenderMichael e1ce7ed
Merge branch 'trunk' into local-value
RenderMichael efd0058
Use var
RenderMichael 64c5eb0
Use in-line literals for `LocalValue` conversions, use a separate fix…
RenderMichael e647628
Merge branch 'trunk' into local-value
RenderMichael d0da6e2
Use int literal
RenderMichael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.