[dotnet] [bidi] Make RealmInfo as not nested

[nvborisenko]

User description

Motivation and Context

Contributes to #15407

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement, Tests

---

Description

• Replaced nested RealmInfo types with standalone types for better extensibility.

• Updated JSON serialization and deserialization to use new standalone RealmInfo types.

• Refactored test cases to align with the new RealmInfo type structure.

• Improved code maintainability by removing nested type constraints.

---

Changes walkthrough 📝

	Relevant files
Enhancement	BiDiJsonSerializerContext.cs Update JSON serialization for standalone `RealmInfo` types dotnet/src/webdriver/BiDi/Communication/Json/BiDiJsonSerializerContext.cs Replaced nested RealmInfo types with standalone types in JSON serialization attributes. Updated type references to new standalone RealmInfo types. +8/-8      RealmInfoConverter.cs Update deserialization for standalone `RealmInfo` types    dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RealmInfoConverter.cs Updated JSON deserialization logic to use standalone RealmInfo types. Replaced nested type references with new standalone types. +8/-8      RealmInfo.cs Refactor `RealmInfo` nested types to standalone records    dotnet/src/webdriver/BiDi/Modules/Script/RealmInfo.cs Refactored RealmInfo nested types into standalone types. Added new standalone records for each RealmInfo type. Removed nested type definitions from RealmInfo. +20/-21
Tests	ScriptCommandsTest.cs Update test cases for standalone `RealmInfo` types              dotnet/test/common/BiDi/Script/ScriptCommandsTest.cs Updated test cases to use standalone RealmInfo types. Replaced assertions for nested types with standalone type checks. +6/-6      ScriptEventsTest.cs Update event tests for standalone `RealmInfo` types            dotnet/test/common/BiDi/Script/ScriptEventsTest.cs Modified event listener test to use standalone RealmInfo types. Updated assertions to reflect new type structure. +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15407 - PR Code Verified Compliant requirements: Replace nested DTO types with standalone types Avoid using nested types that reserve names in parent classes Requires further human verification: Verify that all nested types have been replaced, not just RealmInfo Check if the implementation follows the pattern change from new Locator.Css("div") to new CssLocator("div")

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Commented Code The PR contains commented JSON polymorphic attribute code that should be reviewed. These comments might be related to a known issue (as indicated by the GitHub issue link), but it's worth confirming if they should remain commented in the final implementation. //[JsonPolymorphic(TypeDiscriminatorPropertyName = "type")] //[JsonDerivedType(typeof(WindowRealmInfo), "window")] //[JsonDerivedType(typeof(DedicatedWorkerRealmInfo), "dedicated-worker")] //[JsonDerivedType(typeof(SharedWorkerRealmInfo), "shared-worker")] //[JsonDerivedType(typeof(ServiceWorkerRealmInfo), "service-worker")] //[JsonDerivedType(typeof(WorkerRealmInfo), "worker")] //[JsonDerivedType(typeof(PaintWorkletRealmInfo), "paint-worklet")] //[JsonDerivedType(typeof(AudioWorkletRealmInfo), "audio-worklet")] //[JsonDerivedType(typeof(WorkletRealmInfo), "worklet")]

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Enable polymorphic serialization Update the commented JSON polymorphic attributes to use the new standalone types. Since the nested types have been replaced with standalone types, these attributes should be uncommented to ensure proper polymorphic serialization/deserialization. dotnet/src/webdriver/BiDi/Modules/Script/RealmInfo.cs [25-33] -//[JsonPolymorphic(TypeDiscriminatorPropertyName = "type")] -//[JsonDerivedType(typeof(WindowRealmInfo), "window")] -//[JsonDerivedType(typeof(DedicatedWorkerRealmInfo), "dedicated-worker")] -//[JsonDerivedType(typeof(SharedWorkerRealmInfo), "shared-worker")] -//[JsonDerivedType(typeof(ServiceWorkerRealmInfo), "service-worker")] -//[JsonDerivedType(typeof(WorkerRealmInfo), "worker")] -//[JsonDerivedType(typeof(PaintWorkletRealmInfo), "paint-worklet")] -//[JsonDerivedType(typeof(AudioWorkletRealmInfo), "audio-worklet")] -//[JsonDerivedType(typeof(WorkletRealmInfo), "worklet")] +[JsonPolymorphic(TypeDiscriminatorPropertyName = "type")] +[JsonDerivedType(typeof(WindowRealmInfo), "window")] +[JsonDerivedType(typeof(DedicatedWorkerRealmInfo), "dedicated-worker")] +[JsonDerivedType(typeof(SharedWorkerRealmInfo), "shared-worker")] +[JsonDerivedType(typeof(ServiceWorkerRealmInfo), "service-worker")] +[JsonDerivedType(typeof(WorkerRealmInfo), "worker")] +[JsonDerivedType(typeof(PaintWorkletRealmInfo), "paint-worklet")] +[JsonDerivedType(typeof(AudioWorkletRealmInfo), "audio-worklet")] +[JsonDerivedType(typeof(WorkletRealmInfo), "worklet")] Apply this suggestion Suggestion importance[1-10]: 8 __ Why: This suggestion correctly identifies that the JSON polymorphic attributes should be uncommented now that the nested types have been replaced with standalone types. Enabling these attributes is important for proper type discrimination during serialization/deserialization, which is critical for the BiDi protocol's functionality.	Medium
Learned best practice	Use TryGetProperty to safely check for JSON property existence before accessing it to prevent potential JsonException The code directly accesses the "type" property without checking if it exists first, which could throw a JsonException if the property is missing. Use TryGetProperty to safely check for the property's existence before attempting to access it. dotnet/src/webdriver/BiDi/Communication/Json/Converters/Polymorphic/RealmInfoConverter.cs [34-45] -return jsonDocument.RootElement.GetProperty("type").ToString() switch +if (!jsonDocument.RootElement.TryGetProperty("type", out JsonElement typeElement)) + return null; + +return typeElement.ToString() switch { "window" => jsonDocument.Deserialize<WindowRealmInfo>(options), "dedicated-worker" => jsonDocument.Deserialize<DedicatedWorkerRealmInfo>(options), "shared-worker" => jsonDocument.Deserialize<SharedWorkerRealmInfo>(options), "service-worker" => jsonDocument.Deserialize<ServiceWorkerRealmInfo>(options), "worker" => jsonDocument.Deserialize<WorkerRealmInfo>(options), "paint-worklet" => jsonDocument.Deserialize<PaintWorkletRealmInfo>(options), "audio-worklet" => jsonDocument.Deserialize<AudioWorkletRealmInfo>(options), "worklet" => jsonDocument.Deserialize<WorkletRealmInfo>(options), _ => null, }; Apply this suggestion Suggestion importance[1-10]: 6	Low
More