Skip to content

[dotnet] [bidi] Decouple ScreenshotOrigin in BrowsingContext module #15488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025
Merged

[dotnet] [bidi] Decouple ScreenshotOrigin in BrowsingContext module #15488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace OpenQA.Selenium.BiDi.Modules.BrowsingContext;
internal class CaptureScreenshotCommand(CaptureScreenshotCommandParameters @params)
: Command<CaptureScreenshotCommandParameters>(@params, "browsingContext.captureScreenshot");

internal record CaptureScreenshotCommandParameters(BrowsingContext Context, CaptureScreenshotOptions.ScreenshotOrigin? Origin, ImageFormat? Format, ClipRectangle? Clip) : CommandParameters;
internal record CaptureScreenshotCommandParameters(BrowsingContext Context, ScreenshotOrigin? Origin, ImageFormat? Format, ClipRectangle? Clip) : CommandParameters;

public record CaptureScreenshotOptions : CommandOptions
{
Expand All @@ -34,12 +34,12 @@ public record CaptureScreenshotOptions : CommandOptions
public ImageFormat? Format { get; set; }

public ClipRectangle? Clip { get; set; }
}

public enum ScreenshotOrigin
{
Viewport,
Document
}
public enum ScreenshotOrigin
{
Viewport,
Document
}

public record struct ImageFormat(string Type)
Expand Down
4 changes: 2 additions & 2 deletions dotnet/test/common/BiDi/BrowsingContext/BrowsingContextTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ public async Task CanCaptureScreenshotWithParameters()
{
var screenshot = await context.CaptureScreenshotAsync(new()
{
Origin = CaptureScreenshotOptions.ScreenshotOrigin.Document,
Origin = ScreenshotOrigin.Document,
Clip = new BoxClipRectangle(5, 5, 10, 10)
});

Expand All @@ -272,7 +272,7 @@ public async Task CanCaptureScreenshotOfViewport()
{
var screenshot = await context.CaptureScreenshotAsync(new()
{
Origin = CaptureScreenshotOptions.ScreenshotOrigin.Viewport,
Origin = ScreenshotOrigin.Viewport,
Clip = new BoxClipRectangle(5, 5, 10, 10)
});

Expand Down