-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Remove the wgxpath library
#15498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove the wgxpath library
#15498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to include this to support IE as it didn't have an underlying XPath implementation available to JS scripts to use. The `IEDriverServer` hasn't been recompiled for a while now, and no other driver needs to have an xpath shim. Removing it should be a no-op.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Sep 15, 2025
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
We needed to include this to support IE as it didn't have an underlying XPath implementation available to JS scripts to use.
The
IEDriverServerhasn't been recompiled for a while now, and no other driver needs to have an xpath shim. Removing it should be a no-op.PR Type
Enhancement, Documentation
Description
Removed the
wgxpathlibrary and all associated files, as it is no longer needed due to lack of support for IE.Replaced and simplified JavaScript implementations for
findElements.js,getAttribute.js, andisDisplayed.jswith modern, efficient logic.Added a new Rake task
:atomsto generate JavaScript atom files, improving build automation.Updated documentation in
domcore.jsto remove references towgxpathand clarify dependencies.Deleted all files related to the
wgxpathlibrary from thethird_partydirectory.Changes walkthrough 📝
4 files
findElements.js
Simplified and replaced the `findElements.js` implementation.rb/lib/selenium/webdriver/atoms/findElements.js
function.
Rakefile
Added Rake task for generating JavaScript atom files.Rakefile
:atomsto generate JavaScript atom files.directory.
isDisplayed.js
Refactor and replace `wgxpath` with modern XPath handling.rb/lib/selenium/webdriver/atoms/isDisplayed.js
wgxpathlibrary and its associated code.performance and maintainability.
getAttribute.js
Replaced `getAttribute.js` with a simplified implementation.rb/lib/selenium/webdriver/atoms/getAttribute.js
of JavaScript code.
1 files
domcore.js
Updated documentation to remove `wgxpath` references.javascript/atoms/domcore.js
wgxpathlibrary.
sizzle.33 files