Skip to content

[js] add --websocket-port flag when not connecting to existing connection on firefox #15513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[js] add --websocket-port flag when not connecting to existing connection on firefox #15513

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6079f27
[js] add --websocket-port flag when not connecting to existing connec…
Delta456 Mar 26, 2025
cc11dd5
use correct method
Delta456 Mar 26, 2025
de20051
fix code
Delta456 Mar 26, 2025
783c608
Merge branch 'trunk' into js_ws_port
Delta456 Mar 26, 2025
ff17596
fix typo
harsha509 Mar 28, 2025
03fbccf
Merge branch 'trunk' into js_ws_port
harsha509 Mar 28, 2025
f094133
Update index.js
harsha509 Mar 30, 2025
e504ad0
Merge branch 'trunk' into js_ws_port
harsha509 Mar 30, 2025
4b40ce2
Merge branch 'trunk' into js_ws_port
harsha509 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions javascript/selenium-webdriver/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const BrowsingContext = require('./bidi/browsingContext')
const BrowsingContextInspector = require('./bidi/browsingContextInspector')
const ScriptManager = require('./bidi/scriptManager')
const NetworkInspector = require('./bidi/networkInspector')
const portprober = require('./net/portprober')
const version = require('./package.json').version

const Browser = capabilities.Browser
Expand Down Expand Up @@ -679,6 +680,11 @@ class Builder {
if (this.firefoxService_) {
service = this.firefoxService_.build()
}
// Allocate a free port for the websocket only when not connecting to an existing instance
// This avoids conflicts when multiple Firefox instances have started
if (!service?.options_.args.includes('--connect-existing')) {
service?.addArguments('--websocket-port', `${portprober.findFreePort()}`)
}
return createDriver(firefox.Driver, capabilities, service)
}

Expand Down
Loading