Skip to content

[rb] Allow symbols again to be passed on delete_cookie #15519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

[rb] Allow symbols again to be passed on delete_cookie #15519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c317d8
[build] allow tests tagged exclusive-if-local to run on rbe
titusfortner Mar 22, 2025
f05e0eb
Fix bug where symbol is not accepting on delete cookie
aguspe Mar 26, 2025
282dbe2
Merge branch 'trunk' into rb_delete_cookie_issue
aguspe Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rb/lib/selenium/webdriver/remote/bridge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ def add_cookie(cookie)
end

def delete_cookie(name)
raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.strip.empty?
raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.to_s.strip.empty?

execute :delete_cookie, name: name
end
Expand Down
6 changes: 6 additions & 0 deletions rb/spec/integration/selenium/webdriver/manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,12 @@ module WebDriver
expect { driver.manage.delete_cookie(nil) }
.to raise_error(ArgumentError, /Cookie name cannot be null or empty/)
end

it 'allows deleting a cookies using a symbol' do
driver.manage.add_cookie name: :foo, value: 'bar'
driver.manage.delete_cookie(:foo)
expect(driver.manage.all_cookies).to be_empty
end
end
end # Options
end # WebDriver
Expand Down
Loading