Skip to content

[py] Fix FedCM tests leaking state #15583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

[py] Fix FedCM tests leaking state #15583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91e4c15
[py] Fix FedCM tests leaking state
cgoldberg Apr 7, 2025
6e0319b
Merge branch 'trunk' into py-fedcm-dismiss-dialog
cgoldberg Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions py/test/selenium/webdriver/common/fedcm_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,30 +62,35 @@ def test_trigger_and_verify_dialog_title(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
assert dialog.title == "Sign in to localhost with localhost"
dialog.dismiss()

def test_trigger_and_verify_dialog_subtitle(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
assert dialog.subtitle is None
dialog.dismiss()

def test_trigger_and_verify_dialog_type(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
assert dialog.type == "AccountChooser"
dialog.dismiss()

def test_trigger_and_verify_account_list(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
accounts = dialog.get_accounts()
assert len(accounts) > 0
assert accounts[0].name == "John Doe"
dialog.dismiss()

def test_select_account(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
dialog.select_account(1)
driver.fedcm_dialog() # Wait for dialog to become interactable
# dialog.click_continue()
dialog.dismiss()

def test_dialog_cancel(self, driver):
driver.execute_script("triggerFedCm();")
Expand Down Expand Up @@ -136,3 +141,4 @@ def test_verify_dialog_type_after_cooldown_reset(self, driver):
driver.execute_script("triggerFedCm();")
dialog = driver.fedcm_dialog()
assert dialog.type == "AccountChooser"
dialog.dismiss()
Loading