Skip to content

[py] Fix failing test for Edge logging #15605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

[py] Fix failing test for Edge logging #15605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions py/test/selenium/webdriver/edge/edge_service_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,30 @@ def test_uses_edgedriver_logging(clean_driver, driver_executable) -> None:
log_file = "msedgedriver.log"
service_args = ["--append-log"]

service = Service(
service1 = Service(
log_output=log_file,
service_args=service_args,
executable_path=driver_executable,
)

service2 = Service(
log_output=log_file,
service_args=service_args,
executable_path=driver_executable,
)

driver1 = None
driver2 = None
try:
driver1 = clean_driver(service=service)
driver1 = clean_driver(service=service1)
with open(log_file) as fp:
lines = len(fp.readlines())
driver2 = clean_driver(service=service)
driver2 = clean_driver(service=service2)
with open(log_file) as fp:
assert len(fp.readlines()) >= 2 * lines
finally:
driver1.quit()
if driver1:
driver1.quit()
if driver2:
driver2.quit()
os.remove(log_file)
Expand Down
Loading