Skip to content

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented May 3, 2025

User description

💥 What does this PR do?

This PR changes the Mypy configuration (for type checking) to exclude files in the py/selenium/webdriver/common/devtools directory.

This is a prelude to fixing type checking across the Python bindings. Even with this change, we currently have 120 errors in 30 files when running Mypy!!

🔧 Implementation Notes

We don't really care about type checking in the generated devtools files (our linters skip them also)


Note: we don't fail CI for type checking errors


PR Type

Enhancement


Description

  • Excludes devtools directory from MyPy type checking

  • Updates MyPy configuration in pyproject.toml

  • Prepares for broader type checking improvements


Changes walkthrough 📝

Relevant files
Configuration changes
pyproject.toml
Exclude devtools directory from MyPy type checking             

py/pyproject.toml

  • Adds MyPy exclude directive for selenium/webdriver/common/devtools
  • Adjusts type checking scope for Python project
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label May 3, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 3, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants